Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Bradford Wetmore 
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov  wrote:

> Let's take advantage of Java 7 language feature - "Catching Multiple 
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' 
> statement

LGTM

-

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8081

Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Bradford Wetmore 
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov  wrote:

> Let's take advantage of Java 7 language feature - "Catching Multiple 
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' 
> statement

src/java.base/share/classes/java/net/URI.java line 47:

> 45: import sun.nio.cs.UTF_8;
> 46: 
> 47: import java.lang.Character; // for javadoc

Looks like the javadoc comment no longer applies, so should be ok to remove.

-

PR: https://git.openjdk.java.net/jdk/pull/8081

Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Iris Clark 
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov  wrote:

> Let's take advantage of Java 7 language feature - "Catching Multiple 
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' 
> statement

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8081

Re: RFR: 8284567: Collapse identical catch branches in java.base

2022-04-08 Thread Joe Darcy 
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov  wrote:

> Let's take advantage of Java 7 language feature - "Catching Multiple 
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' 
> statement

Core libs changes look okay.

I assume the docs build also works fine with the import statements removed.

-

Marked as reviewed by darcy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8081

RFR: 8284567: Collapse identical catch branches in java.base

2022-04-07 Thread Andrey Turbanov 
Let's take advantage of Java 7 language feature - "Catching Multiple Exception 
Types".
It simplifies code. Reduces duplication.
Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' statement

-

Commit messages:
 - Merge remote-tracking branch 'origin/master' into 
collapse_identical_catch_java.base
 - [PATCH] Collapse identical catch branches in java.base
 - [PATCH] Collapse identical catch branches in java.base

Changes: https://git.openjdk.java.net/jdk/pull/8081/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8081&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284567
  Stats: 106 lines in 17 files changed: 0 ins; 60 del; 46 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8081.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8081/head:pull/8081

PR: https://git.openjdk.java.net/jdk/pull/8081