Re: RFR: 8286850: [macos] Add support for signing user provided app image [v3]

2022-06-03 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 02:03:35 GMT, Alexander Matveev  wrote:

>> - Added support for signing predefined application image.
>>  - Following command can be used to sign predefined application images: 
>> jpackage --type app-image --app-image Test.app --mac-sign [additional 
>> signing options]
>>  - Main class and if --mac-app-store was specified will be saved in 
>> .jpackage.xml. Both values are required for signing. Main class is to 
>> generate default identity and --mac-app-store to do correct signing for App 
>> Store.
>>  - Signing is done exactly same as when generating app bundle. Unsigned, 
>> signed or partially signed app images are supported. App image will be 
>> completely unsigned before signing.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8286850: [macos] Add support for signing user provided app image [v3]

Marked as reviewed by asemenyuk (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8987


Re: RFR: 8286850: [macos] Add support for signing user provided app image [v3]

2022-06-02 Thread Alexander Matveev
> - Added support for signing predefined application image.
>  - Following command can be used to sign predefined application images: 
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing 
> options]
>  - Main class and if --mac-app-store was specified will be saved in 
> .jpackage.xml. Both values are required for signing. Main class is to 
> generate default identity and --mac-app-store to do correct signing for App 
> Store.
>  - Signing is done exactly same as when generating app bundle. Unsigned, 
> signed or partially signed app images are supported. App image will be 
> completely unsigned before signing.

Alexander Matveev has updated the pull request incrementally with one 
additional commit since the last revision:

  8286850: [macos] Add support for signing user provided app image [v3]

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8987/files
  - new: https://git.openjdk.java.net/jdk/pull/8987/files/65df10e9..598b576d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8987=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8987=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8987.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8987/head:pull/8987

PR: https://git.openjdk.java.net/jdk/pull/8987