Re: RFR: JDK-8219678: CLI changes in jpackage
On 3/4/2019 8:46 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8219678/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java.frames.html Line 32: Do we need this import? I do not see any changes which might require it. Thanks - I had removed that line from several other files where I didn't think it was needed - and got an error. I must have added it to this file when restoring it in the several other files. I will fix. /Andy Otherwise looks fine. Thanks, Alexander On 3/3/2019 7:48 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change modifies the CLI and other behavior as described in [1] [1] https://bugs.openjdk.java.net/browse/JDK-8219678 [2] http://cr.openjdk.java.net/~herrick/8219678/ /Andy
Re: RFR: JDK-8219678: CLI changes in jpackage
Hi Andy, http://cr.openjdk.java.net/~herrick/8219678/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java.frames.html Line 32: Do we need this import? I do not see any changes which might require it. Otherwise looks fine. Thanks, Alexander On 3/3/2019 7:48 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change modifies the CLI and other behavior as described in [1] [1] https://bugs.openjdk.java.net/browse/JDK-8219678 [2] http://cr.openjdk.java.net/~herrick/8219678/ /Andy
RFR: JDK-8219678: CLI changes in jpackage
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change modifies the CLI and other behavior as described in [1] [1] https://bugs.openjdk.java.net/browse/JDK-8219678 [2] http://cr.openjdk.java.net/~herrick/8219678/ /Andy
