Re: RFR: JDK-8226534: combination of windows options cause exception in MsiBundler

2019-08-13 Thread Alexey Semenyuk 

Looks good.

- Alexey

On 8/12/2019 8:38 PM, Alexander Matveev wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


- Fixed by adding --install-dir folders to RemoveFile table as per 
Wixs requirements.


[1] https://bugs.openjdk.java.net/browse/JDK-8226534

[2] http://cr.openjdk.java.net/~almatvee/8226534/webrev.00/

Thanks,
Alexander

Re: RFR: JDK-8226534: combination of windows options cause exception in MsiBundler

2019-08-12 Thread Andy Herrick 

looks good.

/Andy

On 8/12/2019 8:38 PM, Alexander Matveev wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


- Fixed by adding --install-dir folders to RemoveFile table as per 
Wixs requirements.


[1] https://bugs.openjdk.java.net/browse/JDK-8226534

[2] http://cr.openjdk.java.net/~almatvee/8226534/webrev.00/

Thanks,
Alexander

RFR: JDK-8226534: combination of windows options cause exception in MsiBundler

2019-08-12 Thread Alexander Matveev 

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


- Fixed by adding --install-dir folders to RemoveFile table as per Wixs 
requirements.


[1] https://bugs.openjdk.java.net/browse/JDK-8226534

[2] http://cr.openjdk.java.net/~almatvee/8226534/webrev.00/

Thanks,
Alexander