Re: RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application
On 8/19/2019 8:17 PM, Andy Herrick wrote: On 8/19/2019 7:51 PM, Alexey Semenyuk wrote: Looks good. BTW, we can statically link with runtime app launcher and avoid copying a bunch of MS dll-s to install bin directory. I'm not sure if that's true, but it would be great if it is. The app launcher creates the virtual machine and runs the app in the launcher's process, Wouldn't it cause a problem when the runtime and the app are dynamically linked ? I don't think there will be any issues with this. - Alexey /Andy - Alexey On 8/19/2019 7:23 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2] http://cr.openjdk.java.net/~almatvee/8229788/webrev.00/ Thanks, Alexander
Re: RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application
On 8/19/2019 7:51 PM, Alexey Semenyuk wrote: Looks good. BTW, we can statically link with runtime app launcher and avoid copying a bunch of MS dll-s to install bin directory. I'm not sure if that's true, but it would be great if it is. The app launcher creates the virtual machine and runs the app in the launcher's process, Wouldn't it cause a problem when the runtime and the app are dynamically linked ? /Andy - Alexey On 8/19/2019 7:23 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2] http://cr.openjdk.java.net/~almatvee/8229788/webrev.00/ Thanks, Alexander
Re: RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application
looks good. /Andy On 8/19/2019 7:23 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2] http://cr.openjdk.java.net/~almatvee/8229788/webrev.00/ Thanks, Alexander
Re: RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application
Looks good. BTW, we can statically link with runtime app launcher and avoid copying a bunch of MS dll-s to install bin directory. - Alexey On 8/19/2019 7:23 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2] http://cr.openjdk.java.net/~almatvee/8229788/webrev.00/ Thanks, Alexander
RFR: JDK-8229788: Error dialog displays with DLL issue when installing WinChooserTest application
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by statically linking with runtime. [1] https://bugs.openjdk.java.net/browse/JDK-8229788 [2] http://cr.openjdk.java.net/~almatvee/8229788/webrev.00/ Thanks, Alexander
