Re: RFR: JDK-823359: Reorder jpackage help text to focus on package
It seems fine, but it might be even better to have both the non-modular and modular application examples be for the default package case and have a single example of --app-image. Also, I presume `--package-type` will be replaced with `--type` (or `-t`) to match the change in command line option name? -- Kevin On 11/8/2019 6:39 PM, Alexey Semenyuk wrote: Looks good On 11/8/2019 11:03 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix reorders the sample usage in the help text. [1] https://bugs.openjdk.java.net/browse/JDK-8233591 [2] https://cr.openjdk.java.net/~herrick/8233591 /Andy
Re: RFR: JDK-823359: Reorder jpackage help text to focus on package
Looks good On 11/8/2019 11:03 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix reorders the sample usage in the help text. [1] https://bugs.openjdk.java.net/browse/JDK-8233591 [2] https://cr.openjdk.java.net/~herrick/8233591 /Andy
RFR: JDK-823359: Reorder jpackage help text to focus on package
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix reorders the sample usage in the help text. [1] https://bugs.openjdk.java.net/browse/JDK-8233591 [2] https://cr.openjdk.java.net/~herrick/8233591 /Andy
