Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Phil Race 

ok. all good.

-phil

On 12/11/19 12:14 PM, Alexey Semenyuk wrote:

Yes, I did a test build.

- Alexey

On 12/11/2019 1:48 PM, Phil Race wrote:

Looks OK. I presume you did a test build in our build system ?

-phil

On 12/11/19 10:46 AM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Alexey Semenyuk 

Yes, I did a test build.

- Alexey

On 12/11/2019 1:48 PM, Phil Race wrote:

Looks OK. I presume you did a test build in our build system ?

-phil

On 12/11/19 10:46 AM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Andy Herrick 

looks good

/Andy

On 12/11/2019 1:46 PM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Arthur Eubanks 
Looks good, thanks for fixing this!

On Wed, Dec 11, 2019 at 10:55 AM Erik Joelsson 
wrote:

> Looks good.
>
> /Erik
>
> On 2019-12-11 10:46, Alexey Semenyuk wrote:
> > Please review fix [2] for jpackage bug [1].
> >
> > - adds $(X_CFLAGS) to compiler command line.
> >
> > Patch contributed by Arthur Eubanks (aeuba...@google.com).
> >
> > - Alexey
> >
> > [1] https://bugs.openjdk.java.net/browse/JDK-8235728
> >
> > [2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00
> >
>

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Erik Joelsson 

Looks good.

/Erik

On 2019-12-11 10:46, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Phil Race 

Looks OK. I presume you did a test build in our build system ?

-phil

On 12/11/19 10:46 AM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

2019-12-11 Thread Alexey Semenyuk 

Please review fix [2] for jpackage bug [1].

- adds $(X_CFLAGS) to compiler command line.

Patch contributed by Arthur Eubanks (aeuba...@google.com).

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8235728

[2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00