Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" Amazing how many places the word incubator appeared. I am approving on the understanding that all the automated jpackage tests pass on all platforms. - Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 23:28:24 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8252870: Finalize (remove "incubator" from) jpackage >> - reverting two auto-generated files, and changing module-info to >> "@since 16" > > Marked as reviewed by almatvee (Committer). > src/jdk.jpackage/macosx/classes/module-info.java.extra > jdk.jpackage.internal.MacAppBundler, > jdk.jpackage.internal.MacAppStoreBundler, not related to this change directly, but even in 14 there was no MacAppStoreBundler - PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" Looks good. I double-checked all of the file renames and all are exactly as expected. The diffs got a bit confused in a couple cases, where it thought that a renamed and modified file was copied from somewhere else (see inline comments), but that can happen given that git doesn't actually track renames and copies). - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 21:30:05 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8252870: Finalize (remove "incubator" from) jpackage >> - reverting two auto-generated files, and changing module-info to >> "@since 16" > > src/jdk.jpackage/linux/classes/module-info.java.extra line 29: > >> 27: jdk.jpackage.internal.LinuxAppBundler, >> 28: jdk.jpackage.internal.LinuxDebBundler, >> 29: jdk.jpackage.internal.LinuxRpmBundler; > > Not sure why it was changed. Looks like git recorded file renaming > incorrectly. Yes, sometime GIt / Github get a bit confused about identifying rename/copy when generating a diff for a renamed file with changes. The result is correct, but the diff looks odd. > src/jdk.jpackage/macosx/classes/module-info.java.extra line 30: > >> 28: jdk.jpackage.internal.MacAppStoreBundler, >> 29: jdk.jpackage.internal.MacDmgBundler, >> 30: jdk.jpackage.internal.MacPkgBundler; > > Looks like another rename issue. Yes (or more precisely another issue displaying the diffs for a renamed file with changes). - PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" src/jdk.jpackage/linux/classes/module-info.java.extra line 29: > 27: jdk.jpackage.internal.LinuxAppBundler, > 28: jdk.jpackage.internal.LinuxDebBundler, > 29: jdk.jpackage.internal.LinuxRpmBundler; Not sure why it was changed. Looks like git recorded file renaming incorrectly. src/jdk.jpackage/macosx/classes/module-info.java.extra line 30: > 28: jdk.jpackage.internal.MacAppStoreBundler, > 29: jdk.jpackage.internal.MacDmgBundler, > 30: jdk.jpackage.internal.MacPkgBundler; Looks like another rename issue. src/jdk.jpackage/windows/classes/module-info.java.extra line 29: > 27: jdk.jpackage.internal.WinAppBundler, > 28: jdk.jpackage.internal.WinExeBundler, > 29: jdk.jpackage.internal.WinMsiBundler; Another rename issue. - PR: https://git.openjdk.java.net/jdk/pull/633
Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote: >> JDK-8252870: Finalize (remove "incubator" from) jpackage > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8252870: Finalize (remove "incubator" from) jpackage > - reverting two auto-generated files, and changing module-info to "@since > 16" Build changes look good. - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/633
