Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream [v2]
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into JDK-8276674 - Fixed @code and @link in some javadoc for JDK-8276674 - Changes: https://git.openjdk.java.net/jdk/pull/6443/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6443=01 Stats: 13 lines in 8 files changed: 0 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk/pull/6443.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6443/head:pull/6443 PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote: > JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream Given that this PR affects files that aren't rooted under java/util/stream, I would either rename the PR or exclude the unrelated files. If this PR is going to sit there for some more time, I would prefer the latter. This is because the PR has already conflicted with a few other issues related to malformed javadoc tags (e.g. JDK-8276683 and JDK-8276684). So either rename and integrate soon, or exclude the unrelated files. - PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 25 Nov 2021 00:31:46 GMT, Pavel Rappo wrote:
>> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java
> line 63:
>
>> 61: * Helper class to generate stable positions for AST nodes occurring
>> in diagnostic arguments.
>> 62: * If the AST node appears in the same line number as the main
>> diagnostic, the line is information is omitted.
>> 63: * Otherwise both line and column information is included, using the
>> format {@code line:col}".
>
> Not a showstopper by any means. But while you are at it, maybe you could also
> fix this?
>
> Suggestion:
>
> * If the AST node appears in the same line number as the main
> diagnostic, the line information is omitted.
> * Otherwise both line and column information is included, using the
> format {@code line:col}.
This part was recently integrated in https://github.com/openjdk/jdk/pull/6602.
I assume there will be a trivial merge conflict to resolve.
-
PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Looks good.
src/jdk.compiler/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java
line 63:
> 61: * Helper class to generate stable positions for AST nodes occurring
> in diagnostic arguments.
> 62: * If the AST node appears in the same line number as the main
> diagnostic, the line is information is omitted.
> 63: * Otherwise both line and column information is included, using the
> format {@code line:col}".
Not a showstopper by any means. But while you are at it, maybe you could also
fix this?
Suggestion:
* If the AST node appears in the same line number as the main diagnostic,
the line information is omitted.
* Otherwise both line and column information is included, using the format
{@code line:col}.
-
Marked as reviewed by prappo (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 18 Nov 2021 19:18:24 GMT, Jonathan Gibbons wrote: > Remarkable to have not been noticed for so long! Remarkable, but not too surprising: the PR consists of source files and tests that are not part of the API Documentation. - PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote: > JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6443
Re: RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote: > JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream Remarkable to have not been noticed for so long! - Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6443
RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream - Commit messages: - Fixed @code and @link in some javadoc for JDK-8276674 Changes: https://git.openjdk.java.net/jdk/pull/6443/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6443=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276674 Stats: 14 lines in 9 files changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/6443.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6443/head:pull/6443 PR: https://git.openjdk.java.net/jdk/pull/6443
