Re: RFR: JDK-8286760: Update citation of "Effective Java" second edition to third edition

2022-05-13 Thread Pavel Rappo
On Fri, 13 May 2022 21:17:22 GMT, Joe Darcy  wrote:

> Update reference to the latest "Effective Java" version and switch to cite 
> tags.

Looks good!

1. Had to educate myself on the [cite 
element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-cite-element).
 The HTML spec can amuse at times:

A person's name is not the title of a work — even if people call that 
person a piece of work — and the element must therefore not be used to mark up 
people's names.

2. Indeed, items 69 and 81 are both "Prefer concurrency utilities to wait and 
notify".

-

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8707


Re: RFR: JDK-8286760: Update citation of "Effective Java" second edition to third edition

2022-05-13 Thread Brian Burkhalter
On Fri, 13 May 2022 21:17:22 GMT, Joe Darcy  wrote:

> Update reference to the latest "Effective Java" version and switch to cite 
> tags.

Looks fine.

-

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8707


RFR: JDK-8286760: Update citation of "Effective Java" second edition to third edition

2022-05-13 Thread Joe Darcy
Update reference to the latest "Effective Java" version and switch to cite tags.

-

Commit messages:
 - JDK-8286760: Update citation of "Effective Java" second edition to third 
edition

Changes: https://git.openjdk.java.net/jdk/pull/8707/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8707=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286760
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8707.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8707/head:pull/8707

PR: https://git.openjdk.java.net/jdk/pull/8707