RE: RFR: JDK8u Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit
Thank you Daniel and Sean for your reviews. Regards, Ramanand. > -Original Message- > From: Daniel Fuchs > Sent: Wednesday, December 20, 2017 2:43 PM > To: Ramanand Patil ; core-libs-dev d...@openjdk.java.net> > Subject: Re: RFR: JDK8u Backport of 8153955: increase > java.util.logging.FileHandler MAX_LOCKS limit > > Hi Ramanand, > > On 18/12/2017 11:41, Ramanand Patil wrote: > > Hi all, > > Please review the fix for JDK8u Backport of > https://bugs.openjdk.java.net/browse/JDK-8153955 > > Backport Bug: https://bugs.openjdk.java.net/browse/JDK-8161266 > > Webrev: http://cr.openjdk.java.net/~rpatil/8161266/webrev.00/ > > Looks good to me as well. > > best regards, > > -- daniel > > > > > Summary(also added to backport bug description): > > The fix from JDK9 cannot be backported as is into the jdk8u and earlier > update releases, since it contains JDK API spec changes. > > In JDK9 the fix is added by altering the FileHandler spec, which introduces > > a > new configurable property "java.util.logging.FileHandler.maxLocks" to > java.util.logging.FileHandler, defined in .../conf/logging.properties. > > The solution proposed for update releases is: > > To introduce an internal JDK implementation specific property- > "jdk.internal.FileHandlerLogging.maxLocks" which will be used to > control/override FileHandler's MAX_LOCKS value. The default value of the > maxLocks (100) will be retained if this new System property is not set. The > new property is read only once during FileHandler class initialization. > > > > > > Regards, > > Ramanand. > > >
Re: RFR: JDK8u Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit
Hi Ramanand, On 18/12/2017 11:41, Ramanand Patil wrote: Hi all, Please review the fix for JDK8u Backport of https://bugs.openjdk.java.net/browse/JDK-8153955 Backport Bug: https://bugs.openjdk.java.net/browse/JDK-8161266 Webrev: http://cr.openjdk.java.net/~rpatil/8161266/webrev.00/ Looks good to me as well. best regards, -- daniel Summary(also added to backport bug description): The fix from JDK9 cannot be backported as is into the jdk8u and earlier update releases, since it contains JDK API spec changes. In JDK9 the fix is added by altering the FileHandler spec, which introduces a new configurable property "java.util.logging.FileHandler.maxLocks" to java.util.logging.FileHandler, defined in .../conf/logging.properties. The solution proposed for update releases is: To introduce an internal JDK implementation specific property- "jdk.internal.FileHandlerLogging.maxLocks" which will be used to control/override FileHandler's MAX_LOCKS value. The default value of the maxLocks (100) will be retained if this new System property is not set. The new property is read only once during FileHandler class initialization. Regards, Ramanand.
Re: RFR: JDK8u Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit
Looks fine to me. regards, Sean. On 18/12/2017 11:41, Ramanand Patil wrote: Hi all, Please review the fix for JDK8u Backport of https://bugs.openjdk.java.net/browse/JDK-8153955 Backport Bug: https://bugs.openjdk.java.net/browse/JDK-8161266 Webrev: http://cr.openjdk.java.net/~rpatil/8161266/webrev.00/ Summary(also added to backport bug description): The fix from JDK9 cannot be backported as is into the jdk8u and earlier update releases, since it contains JDK API spec changes. In JDK9 the fix is added by altering the FileHandler spec, which introduces a new configurable property "java.util.logging.FileHandler.maxLocks" to java.util.logging.FileHandler, defined in .../conf/logging.properties. The solution proposed for update releases is: To introduce an internal JDK implementation specific property- "jdk.internal.FileHandlerLogging.maxLocks" which will be used to control/override FileHandler's MAX_LOCKS value. The default value of the maxLocks (100) will be retained if this new System property is not set. The new property is read only once during FileHandler class initialization. Regards, Ramanand.
RFR: JDK8u Backport of 8153955: increase java.util.logging.FileHandler MAX_LOCKS limit
Hi all, Please review the fix for JDK8u Backport of https://bugs.openjdk.java.net/browse/JDK-8153955 Backport Bug: https://bugs.openjdk.java.net/browse/JDK-8161266 Webrev: http://cr.openjdk.java.net/~rpatil/8161266/webrev.00/ Summary(also added to backport bug description): The fix from JDK9 cannot be backported as is into the jdk8u and earlier update releases, since it contains JDK API spec changes. In JDK9 the fix is added by altering the FileHandler spec, which introduces a new configurable property "java.util.logging.FileHandler.maxLocks" to java.util.logging.FileHandler, defined in .../conf/logging.properties. The solution proposed for update releases is: To introduce an internal JDK implementation specific property- "jdk.internal.FileHandlerLogging.maxLocks" which will be used to control/override FileHandler's MAX_LOCKS value. The default value of the maxLocks (100) will be retained if this new System property is not set. The new property is read only once during FileHandler class initialization. Regards, Ramanand.
