Re: RFR:JDK-8066571:UnsupportedTemporalTypeException is thrown not only in the case of unsupported temporal

2015-11-10 Thread Stephen Colebourne 
Nice ti see this fixed
thanks
Stephen


On 9 November 2015 at 21:34, Roger Riggs  wrote:
> Hi Naddesh,
>
> Thanks for fixing this issue.
>
> I can sponsor getting the fix pushed.
>
> Roger
>
>
>
>
> On 11/9/2015 4:16 AM, nadeesh tv wrote:
>
> Hi all,
>
> Please review a fix for
> Bug Id - https://bugs.openjdk.java.net/browse/JDK-8066571
>
> Issue - IsoFields.Unit.issupportedBy was not checking isIso()
>
> Solution - Moved isIso() from Filed to IsoFields sothat both Field and Unit
> can use
>
> Apart from the above fix, corrected a documentaion error in IsoFields -
> QUARTER_OF_YEAR
>
> webrev - http://cr.openjdk.java.net/~ntv/8066571/webrev.04/
>
> --
> Thanks and Regards,
> Nadeesh TV
>
>

Re: RFR:JDK-8066571:UnsupportedTemporalTypeException is thrown not only in the case of unsupported temporal

2015-11-09 Thread Roger Riggs 

Hi Naddesh,

Thanks for fixing this issue.

I can sponsor getting the fix pushed.

Roger



On 11/9/2015 4:16 AM, nadeesh tv wrote:

Hi all,

Please review a fix for
Bug Id - https://bugs.openjdk.java.net/browse/JDK-8066571 



Issue - IsoFields.Unit.issupportedBy was not checking isIso()

Solution - Moved isIso() from Filed to IsoFields sothat both Field and 
Unit can use


Apart from the above fix, corrected a documentaion error in IsoFields 
- QUARTER_OF_YEAR


webrev - http://cr.openjdk.java.net/~ntv/8066571/webrev.04/ 


--
Thanks and Regards,
Nadeesh TV

RFR:JDK-8066571:UnsupportedTemporalTypeException is thrown not only in the case of unsupported temporal

2015-11-09 Thread nadeesh tv 

Hi all,

Please review a fix for
Bug Id - https://bugs.openjdk.java.net/browse/JDK-8066571 



Issue - IsoFields.Unit.issupportedBy was not checking isIso()

Solution - Moved isIso() from Filed to IsoFields sothat both Field and 
Unit can use


Apart from the above fix, corrected a documentaion error in IsoFields - 
QUARTER_OF_YEAR


webrev - http://cr.openjdk.java.net/~ntv/8066571/webrev.04/ 



--
Thanks and Regards,
Nadeesh TV