Re: RFR:JDK-8133079:java.time LocalDate and LocalTime ofInstant() factory methods

2015-11-12 Thread nadeesh tv 

Hi Stephen,
Yes, I will send out a separate RFR for  JDK-8030864
Regards,
Nadeesh
On 11/12/2015 7:11 PM, Stephen Colebourne wrote:

Looks good to me.
Need to ensure that JDK-8030864 also gets tackled, as it is the
inverse operation of these new methods.
thanks
Stephen


On 12 November 2015 at 06:40, nadeesh tv  wrote:

Hi all,

Please review a fix for

Bug Id - https://bugs.openjdk.java.net/browse/JDK-8133079

Enhancement -  Enhance LocalDate and LocalTime by adding .ofInstant(Instant,
ZoneId)

webrev - http://cr.openjdk.java.net/~ntv/8133079/webrev.01/

--
Thanks and Regards,
Nadeesh TV



--
Thanks and Regards,
Nadeesh TV

Re: RFR:JDK-8133079:java.time LocalDate and LocalTime ofInstant() factory methods

2015-11-12 Thread Stephen Colebourne 
Looks good to me.
Need to ensure that JDK-8030864 also gets tackled, as it is the
inverse operation of these new methods.
thanks
Stephen


On 12 November 2015 at 06:40, nadeesh tv  wrote:
> Hi all,
>
> Please review a fix for
>
> Bug Id - https://bugs.openjdk.java.net/browse/JDK-8133079
>
> Enhancement -  Enhance LocalDate and LocalTime by adding .ofInstant(Instant,
> ZoneId)
>
> webrev - http://cr.openjdk.java.net/~ntv/8133079/webrev.01/
>
> --
> Thanks and Regards,
> Nadeesh TV
>

RFR:JDK-8133079:java.time LocalDate and LocalTime ofInstant() factory methods

2015-11-11 Thread nadeesh tv 

Hi all,

Please review a fix for

Bug Id - https://bugs.openjdk.java.net/browse/JDK-8133079

Enhancement -  Enhance LocalDate and LocalTime by adding 
.ofInstant(Instant, ZoneId)


webrev - http://cr.openjdk.java.net/~ntv/8133079/webrev.01/

--
Thanks and Regards,
Nadeesh TV