RFR (JAXP): 8032392 : Spec: javax.xml.stream.XMLEventFactory/XMLOutputFactory/XMLInputFactory.newFactory(String, ClassLoader) referring to ServiceLoader.load(Class, ClassLoader)

2014-01-24 Thread huizhe wang 

Hi,

Please review a javadoc change to javax.xml.stream factories. This 
change makes it clear that the two args ServiceLoader#load method is 
used when the specified classLoader is not null.


http://cr.openjdk.java.net/~joehw/jdk9/8032392/webrev/

Thanks,
Joe

Re: RFR (JAXP): 8032392 : Spec: javax.xml.stream.XMLEventFactory/XMLOutputFactory/XMLInputFactory.newFactory(String, ClassLoader) referring to ServiceLoader.load(Class, ClassLoader)

2014-01-24 Thread Daniel Fuchs 

Hi,

It looks fine to me Joe.

best regards,

-- daniel

On 1/24/14 9:31 PM, huizhe wang wrote:

Hi,

Please review a javadoc change to javax.xml.stream factories. This 
change makes it clear that the two args ServiceLoader#load method is 
used when the specified classLoader is not null.


http://cr.openjdk.java.net/~joehw/jdk9/8032392/webrev/

Thanks,
Joe

Re: RFR (JAXP): 8032392 : Spec: javax.xml.stream.XMLEventFactory/XMLOutputFactory/XMLInputFactory.newFactory(String, ClassLoader) referring to ServiceLoader.load(Class, ClassLoader)

2014-01-24 Thread Lance Andersen - Oracle 
+1
On Jan 24, 2014, at 3:31 PM, huizhe wang wrote:

 Hi,
 
 Please review a javadoc change to javax.xml.stream factories. This change 
 makes it clear that the two args ServiceLoader#load method is used when the 
 specified classLoader is not null.
 
 http://cr.openjdk.java.net/~joehw/jdk9/8032392/webrev/
 
 Thanks,
 Joe
 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP): 8032392 : Spec: javax.xml.stream.XMLEventFactory/XMLOutputFactory/XMLInputFactory.newFactory(String, ClassLoader) referring to ServiceLoader.load(Class, ClassLoader)

2014-01-24 Thread huizhe wang 

Thanks Lance, Daniel.

On 1/24/2014 12:53 PM, Lance Andersen - Oracle wrote:

+1
On Jan 24, 2014, at 3:31 PM, huizhe wang wrote:


Hi,

Please review a javadoc change to javax.xml.stream factories. This change makes 
it clear that the two args ServiceLoader#load method is used when the specified 
classLoader is not null.

http://cr.openjdk.java.net/~joehw/jdk9/8032392/webrev/

Thanks,
Joe




Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com