Re: RFR (JAXP) 8058152: JDK accepts XSLT stylesheet having import element erroneously placed

2016-10-12 Thread Joe Wang 

Thanks Naoto, Lance!

I appended _ERR.

-Joe

On 10/12/16, 2:50 PM, Naoto Sato wrote:
+1. You might want to append "_ERR" to the field 
"IMPORT_PRECEDE_OTHERS" to align with other errors (no need for 
further review).


Naoto

On 10/12/16 1:37 PM, Joe Wang wrote:

Hi,

Please review a change to validate that xsl:import element children
/must precede/ all other element children of an 
element, including any  element children as required by
the specification [1].

[1] https://www.w3.org/TR/xslt#import

JBS: https://bugs.openjdk.java.net/browse/JDK-8058152
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8058152/webrev/

Thanks,
Joe

Re: RFR (JAXP) 8058152: JDK accepts XSLT stylesheet having import element erroneously placed

2016-10-12 Thread Naoto Sato 
+1. You might want to append "_ERR" to the field "IMPORT_PRECEDE_OTHERS" 
to align with other errors (no need for further review).


Naoto

On 10/12/16 1:37 PM, Joe Wang wrote:

Hi,

Please review a change to validate that xsl:import element children
/must precede/ all other element children of an 
element, including any  element children as required by
the specification [1].

[1] https://www.w3.org/TR/xslt#import

JBS: https://bugs.openjdk.java.net/browse/JDK-8058152
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8058152/webrev/

Thanks,
Joe

Re: RFR (JAXP) 8058152: JDK accepts XSLT stylesheet having import element erroneously placed

2016-10-12 Thread Lance Andersen 
Looks OK Joe

> On Oct 12, 2016, at 4:37 PM, Joe Wang  wrote:
> 
> Hi,
> 
> Please review a change to validate that xsl:import element children /must 
> precede/ all other element children of an  element, including 
> any  element children as required by the specification [1].
> 
> [1] https://www.w3.org/TR/xslt#import
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8058152
> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8058152/webrev/
> 
> Thanks,
> Joe

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

RFR (JAXP) 8058152: JDK accepts XSLT stylesheet having import element erroneously placed

2016-10-12 Thread Joe Wang 

Hi,

Please review a change to validate that xsl:import element children 
/must precede/ all other element children of an  
element, including any  element children as required by 
the specification [1].


[1] https://www.w3.org/TR/xslt#import

JBS: https://bugs.openjdk.java.net/browse/JDK-8058152
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8058152/webrev/

Thanks,
Joe