Re: RFR (JAXP) 8152530: NullPointerException when xmlns=""

2016-10-11 Thread Naoto Sato 

Thanks, Joe. +1

Naoto

On 10/11/16 2:32 PM, Joe Wang wrote:

Thanks Daniel, Naoto!

Changed to use prefix.isEmpty().

-Joe

On 10/11/16, 1:41 PM, Naoto Sato wrote:

Hi Joe,

You could use prefix.isEmpty() to check if it's an empty string.
Otherwise looks fine to me.

Naoto

On 10/11/16 1:29 PM, Joe Wang wrote:

Hi,

Please review a fix for a NPE when the source contains empty namespace.

JBS: https://bugs.openjdk.java.net/browse/JDK-8152530
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8152530/webrev/

Thanks,
Joe

Re: RFR (JAXP) 8152530: NullPointerException when xmlns=""

2016-10-11 Thread Joe Wang 

Thanks Daniel, Naoto!

Changed to use prefix.isEmpty().

-Joe

On 10/11/16, 1:41 PM, Naoto Sato wrote:

Hi Joe,

You could use prefix.isEmpty() to check if it's an empty string. 
Otherwise looks fine to me.


Naoto

On 10/11/16 1:29 PM, Joe Wang wrote:

Hi,

Please review a fix for a NPE when the source contains empty namespace.

JBS: https://bugs.openjdk.java.net/browse/JDK-8152530
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8152530/webrev/

Thanks,
Joe

Re: RFR (JAXP) 8152530: NullPointerException when xmlns=""

2016-10-11 Thread Naoto Sato 

Hi Joe,

You could use prefix.isEmpty() to check if it's an empty string. 
Otherwise looks fine to me.


Naoto

On 10/11/16 1:29 PM, Joe Wang wrote:

Hi,

Please review a fix for a NPE when the source contains empty namespace.

JBS: https://bugs.openjdk.java.net/browse/JDK-8152530
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8152530/webrev/

Thanks,
Joe

Re: RFR (JAXP) 8152530: NullPointerException when xmlns=""

2016-10-11 Thread Daniel Fuchs 

Looks good to me Joe!

best regards,

-- daniel

On 11/10/16 21:29, Joe Wang wrote:

Hi,

Please review a fix for a NPE when the source contains empty namespace.

JBS: https://bugs.openjdk.java.net/browse/JDK-8152530
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8152530/webrev/

Thanks,
Joe

RFR (JAXP) 8152530: NullPointerException when xmlns=""

2016-10-11 Thread Joe Wang 

Hi,

Please review a fix for a NPE when the source contains empty namespace.

JBS: https://bugs.openjdk.java.net/browse/JDK-8152530
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8152530/webrev/

Thanks,
Joe