Re: RFR (JDK11/java.xml) 8199792: Wrong license header in XMLLimitAnalyzer.java

2018-03-20 Thread Roger Riggs 

Hi Joe,

Looks fine

Roger

On 3/20/18 1:57 PM, Joe Wang wrote:

Hi,

Please help review a quick fix for a license header. Note that I 
didn't change the copyright year since there's no code change, and 
also I'd like to maintain the same copyright year as the other classes 
that were added together with this class.


JBS: https://bugs.openjdk.java.net/browse/JDK-8199792
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8199792/webrev/

Thanks,
Joe

Re: RFR (JDK11/java.xml) 8199792: Wrong license header in XMLLimitAnalyzer.java

2018-03-20 Thread Joe Wang 

Thanks!

On 3/20/2018 11:00 AM, Lance Andersen wrote:

+1
On Mar 20, 2018, at 1:57 PM, Joe Wang > wrote:


Hi,

Please help review a quick fix for a license header. Note that I 
didn't change the copyright year since there's no code change, and 
also I'd like to maintain the same copyright year as the other 
classes that were added together with this class.


JBS: https://bugs.openjdk.java.net/browse/JDK-8199792
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8199792/webrev/ 



Thanks,
Joe




Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JDK11/java.xml) 8199792: Wrong license header in XMLLimitAnalyzer.java

2018-03-20 Thread Lance Andersen 
+1
> On Mar 20, 2018, at 1:57 PM, Joe Wang  wrote:
> 
> Hi,
> 
> Please help review a quick fix for a license header. Note that I didn't 
> change the copyright year since there's no code change, and also I'd like to 
> maintain the same copyright year as the other classes that were added 
> together with this class.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8199792
> webrev: http://cr.openjdk.java.net/~joehw/jdk11/8199792/webrev/
> 
> Thanks,
> Joe

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

RFR (JDK11/java.xml) 8199792: Wrong license header in XMLLimitAnalyzer.java

2018-03-20 Thread Joe Wang 

Hi,

Please help review a quick fix for a license header. Note that I didn't 
change the copyright year since there's no code change, and also I'd 
like to maintain the same copyright year as the other classes that were 
added together with this class.


JBS: https://bugs.openjdk.java.net/browse/JDK-8199792
webrev: http://cr.openjdk.java.net/~joehw/jdk11/8199792/webrev/

Thanks,
Joe