Re: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

2013-02-20 Thread Yekaterina Kantserova 

On 02/19/2013 05:01 PM, Alan Bateman wrote:

On 13/02/2013 09:47, Yekaterina Kantserova wrote:

Hi everyone,

This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
check below is too OS dependent and should be deleted.

...
binPath += File.separatorChar + bin + File.separatorChar + 
executable;

File toolFile = new File(binPath);
== if (!toolFile.exists()) {
throw new RuntimeException(binPath +  does not exist);
}
...

On windows if executable is specified as e.g. 'java', without '.exe', 
the File exists() will fail. But it's still possible to run executable.
Thanks for reviewing this! Yes, Staffan Larsen helped me last time, I 
hope he can do it again.


// Katja

This looks okay to me, do you have someone to push this for you?

-Alan.

Re: RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

2013-02-19 Thread Alan Bateman 

On 13/02/2013 09:47, Yekaterina Kantserova wrote:

Hi everyone,

This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
check below is too OS dependent and should be deleted.

...
binPath += File.separatorChar + bin + File.separatorChar + 
executable;

File toolFile = new File(binPath);
== if (!toolFile.exists()) {
throw new RuntimeException(binPath +  does not exist);
}
...

On windows if executable is specified as e.g. 'java', without '.exe', 
the File exists() will fail. But it's still possible to run executable.

This looks okay to me, do you have someone to push this for you?

-Alan.

RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

2013-02-13 Thread Yekaterina Kantserova 

Hi everyone,

This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
check below is too OS dependent and should be deleted.

...
binPath += File.separatorChar + bin + File.separatorChar + 
executable;

File toolFile = new File(binPath);
== if (!toolFile.exists()) {
throw new RuntimeException(binPath +  does not exist);
}
...

On windows if executable is specified as e.g. 'java', without '.exe', 
the File exists() will fail. But it's still possible to run executable.



Webrev:
http://cr.openjdk.java.net/~ykantser/8008089/webrev.00/

Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008089

Testing:
JPRT

Thanks,
Katja