Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

2020-03-13 Thread Joe Wang 

Thanks Naoto, Lance!

-Joe

On 3/13/20 10:42 AM, Lance Andersen wrote:

+1

On Mar 13, 2020, at 1:32 PM, Joe Wang > wrote:


Please review a quick fix for the missing commas after the 2nd year 
in the copyright header:


diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All 
rights reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All 
rights reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All 
rights reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more



Thanks,
Joe





Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

2020-03-13 Thread Lance Andersen 
+1

> On Mar 13, 2020, at 1:32 PM, Joe Wang  wrote:
> 
> Please review a quick fix for the missing commas after the 2nd year in the 
> copyright header:
> 
> diff --git 
> a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java 
> b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
> --- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
> +++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
> reserved.
>   */
>  /*
>   * Licensed to the Apache Software Foundation (ASF) under one or more
> diff --git 
> a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
>  
> b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
> --- 
> a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
> +++ 
> b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
> reserved.
>   */
>  /*
>   * Licensed to the Apache Software Foundation (ASF) under one or more
> diff --git 
> a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
>  
> b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
> --- 
> a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
> +++ 
> b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
> reserved.
>   */
>  /*
>   * Licensed to the Apache Software Foundation (ASF) under one or more
> 
> 
> 
> Thanks,
> Joe
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

2020-03-13 Thread naoto . sato 

Looks good, Joe.

Naoto

On 3/13/20 10:32 AM, Joe Wang wrote:
Please review a quick fix for the missing commas after the 2nd year in 
the copyright header:


diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java

@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

   */
  /*
   * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 

--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 

+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 


@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

   */
  /*
   * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 

--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 

+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 


@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

   */
  /*
   * Licensed to the Apache Software Foundation (ASF) under one or more



Thanks,
Joe

RFR [15/java.xml] 8240982 Incorrect copyright header in BCEL 6.4.1 sources

2020-03-13 Thread Joe Wang 
Please review a quick fix for the missing commas after the 2nd year in 
the copyright header:


diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java

--- a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
+++ b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Const.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/ExceptionConst.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
diff --git 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
--- 
a/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java
+++ 
b/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights 
reserved.

  */
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more



Thanks,
Joe