Re: RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread Joe Wang 

+1

-Joe

On 6/15/2020 7:09 AM, Roger Riggs wrote:

Please review a test change of the test library HexPrinter.
It should be comparing against the System.lineSeparator.


diff --git a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java 
b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java

--- a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java
+++ b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java
@@ -77,9 +77,9 @@ public class HexPrinterTest {
 Object[][] builtinParams() {
 return new Object[][]{
 {"minimal", "", "%02x", 16, "", 64, 
HexPrinter.Formatters.NONE, ""},
-    {"canonical", "%08x  ", "%02x ", 16, "|", 31, 
HexPrinter.Formatters.PRINTABLE, "|\n"},
-    {"simple", "%5d: ", "%02x ", 16, " // ", 64, 
HexPrinter.Formatters.ASCII, "\n"},
-    {"source", "    ", "(byte)%3d, ", 8, " // ", 64, 
HexPrinter.Formatters.PRINTABLE, "\n"},
+    {"canonical", "%08x  ", "%02x ", 16, "|", 31, 
HexPrinter.Formatters.PRINTABLE, "|" + System.lineSeparator()},
+    {"simple", "%5d: ", "%02x ", 16, " // ", 64, 
HexPrinter.Formatters.ASCII,  System.lineSeparator()},
+    {"source", "    ", "(byte)%3d, ", 8, " // ", 64, 
HexPrinter.Formatters.PRINTABLE,  System.lineSeparator()},

 };
 }


Webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8247521/

Issue:
 https://bugs.openjdk.java.net/browse/JDK-8247521

Thanks, Roger

Re: RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread igor . ignatyev 
Hi Roger,

LGTM,

Thanks,
— Igor

> On Jun 15, 2020, at 7:10 AM, Roger Riggs  wrote:
> 
> Roger

RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread Roger Riggs 

Please review a test change of the test library HexPrinter.
It should be comparing against the System.lineSeparator.


diff --git a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java 
b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java

--- a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java
+++ b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java
@@ -77,9 +77,9 @@ public class HexPrinterTest {
 Object[][] builtinParams() {
 return new Object[][]{
 {"minimal", "", "%02x", 16, "", 64, 
HexPrinter.Formatters.NONE, ""},
-    {"canonical", "%08x  ", "%02x ", 16, "|", 31, 
HexPrinter.Formatters.PRINTABLE, "|\n"},
-    {"simple", "%5d: ", "%02x ", 16, " // ", 64, 
HexPrinter.Formatters.ASCII, "\n"},
-    {"source", "    ", "(byte)%3d, ", 8, " // ", 64, 
HexPrinter.Formatters.PRINTABLE, "\n"},
+    {"canonical", "%08x  ", "%02x ", 16, "|", 31, 
HexPrinter.Formatters.PRINTABLE, "|" + System.lineSeparator()},
+    {"simple", "%5d: ", "%02x ", 16, " // ", 64, 
HexPrinter.Formatters.ASCII,  System.lineSeparator()},
+    {"source", "    ", "(byte)%3d, ", 8, " // ", 64, 
HexPrinter.Formatters.PRINTABLE,  System.lineSeparator()},

 };
 }


Webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8247521/

Issue:
 https://bugs.openjdk.java.net/browse/JDK-8247521

Thanks, Roger