Re: RFR 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x

2012-12-17 Thread Alan Bateman 

On 14/12/2012 17:36, Chris Hegarty wrote:
Strangely, this test passed in my test runs, on all platforms, before 
the push with the changes that pass the TESTVMOPTS, 8003890. It has 
now been seen to fail on some mac machines. There appears to be an 
issue with the use of quotes around TESTVMOPTS. The below change 
resolves the failure on the problem machines, and also continues to 
pass on all other platforms.
I can only guess that sh is a different shell or version. In any case, 
the change looks fine to me.


-Alan

RFR 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x

2012-12-14 Thread Chris Hegarty 
Strangely, this test passed in my test runs, on all platforms, before 
the push with the changes that pass the TESTVMOPTS, 8003890. It has now 
been seen to fail on some mac machines. There appears to be an issue 
with the use of quotes around TESTVMOPTS. The below change resolves the 
failure on the problem machines, and also continues to pass on all other 
platforms.


-
diff -r 8d7323a9d8ed test/java/util/prefs/PrefsSpi.sh
--- a/test/java/util/prefs/PrefsSpi.sh  Thu Dec 13 21:18:27 2012 -0500
+++ b/test/java/util/prefs/PrefsSpi.sh  Fri Dec 14 16:36:17 2012 +
@@ -87,17 +87,17 @@ Sys "$javac" -d jarDir StubPreferencesFa

 case "`uname`" in Windows*|CYGWIN* ) CPS=';';; *) CPS=':';; esac

-Sys "$java" "${TESTVMOPTS}" "-cp" "$TESTCLASSES${CPS}extDir/PrefsSpi.jar" \
+Sys "$java" ${TESTVMOPTS} "-cp" "$TESTCLASSES${CPS}extDir/PrefsSpi.jar" \
 -Djava.util.prefs.PreferencesFactory=StubPreferencesFactory \
 -Djava.util.prefs.userRoot=. \
 PrefsSpi "StubPreferences"
-Sys "$java" "${TESTVMOPTS}" "-cp" "$TESTCLASSES" \
+Sys "$java" ${TESTVMOPTS} "-cp" "$TESTCLASSES" \
 -Djava.util.prefs.userRoot=. \
 PrefsSpi "java.util.prefs.*"
-Sys "$java" "${TESTVMOPTS}" "-cp" "$TESTCLASSES${CPS}extDir/PrefsSpi.jar" \
+Sys "$java" ${TESTVMOPTS} "-cp" "$TESTCLASSES${CPS}extDir/PrefsSpi.jar" \
 -Djava.util.prefs.userRoot=. \
 PrefsSpi "StubPreferences"
-Sys "$java" "${TESTVMOPTS}" "-cp" "$TESTCLASSES" "-Djava.ext.dirs=extDir" \
+Sys "$java" ${TESTVMOPTS} "-cp" "$TESTCLASSES" "-Djava.ext.dirs=extDir" \
 -Djava.util.prefs.userRoot=. \
 PrefsSpi "StubPreferences"

-Chris.