Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown
Hi Alan, Thanks for your review. Yes, spec. change is being tracked. I'll remove that whitespace after doc comment of getProgram method and push it. PS. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.01/ Thanks, -Sundar On 19/10/16, 12:42 PM, Alan Bateman wrote: On 19/10/2016 06:06, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/ This looks okay (except the spurious blank line after the class comment). It's a spec change that will need to be tracked. -Alan
Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown
On 19/10/2016 06:06, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/ This looks okay (except the spurious blank line after the class comment). It's a spec change that will need to be tracked. -Alan
Re: RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown
+1 Hannes > Am 19.10.2016 um 07:06 schrieb Sundararajan Athijegannathan >: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 > > jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ > > nashorn webrev: > http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/ > > Thanks > > -Sundar >
RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8071588 jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/ Thanks -Sundar