Re: RFR 8199773 (bf) XXXBuffer:compareTo method is not working as expected

[Paul Sandoz]

> On Mar 20, 2018, at 10:24 AM, Alan Bateman  wrote:
> 
> 
> 
> On 20/03/2018 17:12, Paul Sandoz wrote:
>> Hi,
>> 
>> Please review this simple fix for a silly mistake when calculating the 
>> result of comparing two buffers:
>> 
>>   
>> http://cr.openjdk.java.net/~psandoz/jdk/JDK-8199773-buffer-compare-value/webrev/
>>  
>> 
>> 
> Looks good to me, we probably should have caught this in the core review.
> 

Thanks. Hard to spot. I am glad the JCK tests found it. I should have realized 
the test needed to do pos/limit as well as pos/limit/slice (the latter caught 
bugs early in the development process).

Paul.

Re: RFR 8199773 (bf) XXXBuffer:compareTo method is not working as expected

[Alan Bateman]

On 20/03/2018 17:12, Paul Sandoz wrote:

Hi,

Please review this simple fix for a silly mistake when calculating the result 
of comparing two buffers:

   http://cr.openjdk.java.net/~psandoz/jdk/JDK-8199773-buffer-compare-value/webrev/ 



Looks good to me, we probably should have caught this in the core review.

-Alan

RFR 8199773 (bf) XXXBuffer:compareTo method is not working as expected

[Paul Sandoz]

Hi,

Please review this simple fix for a silly mistake when calculating the result 
of comparing two buffers:

  
http://cr.openjdk.java.net/~psandoz/jdk/JDK-8199773-buffer-compare-value/webrev/
 


Paul.