Re: RFR 8233048: WeekFields.ISO is not a singleton

2020-07-30 Thread Roger Riggs 

Looks good Naoto.

Thanks, Roger

On 7/30/20 5:53 PM, naoto.s...@oracle.com wrote:

Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8233048

The proposed chageset is located at:

https://cr.openjdk.java.net/~naoto/8233048/webrev.00/

java.time.temporal.WeekFields.ISO is instantiated using the 
constructor, which is a different object returned from 
WeekFields.of(MONDAY, 4). Even though this itself does not cause any 
issues, since objects are "equal", but the fix will provide the 
identity, as WeekFields objects are supposed to be singletons.


Naoto

Re: RFR 8233048: WeekFields.ISO is not a singleton

2020-07-30 Thread Joe Wang 

+1

-Joe

On 7/30/20 2:53 PM, naoto.s...@oracle.com wrote:

Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8233048

The proposed chageset is located at:

https://cr.openjdk.java.net/~naoto/8233048/webrev.00/

java.time.temporal.WeekFields.ISO is instantiated using the 
constructor, which is a different object returned from 
WeekFields.of(MONDAY, 4). Even though this itself does not cause any 
issues, since objects are "equal", but the fix will provide the 
identity, as WeekFields objects are supposed to be singletons.


Naoto

Re: RFR 8233048: WeekFields.ISO is not a singleton

2020-07-30 Thread Stephen Colebourne 
 +1
Stephen

On Thu, 30 Jul 2020 at 22:54,  wrote:
>
> Hi,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8233048
>
> The proposed chageset is located at:
>
> https://cr.openjdk.java.net/~naoto/8233048/webrev.00/
>
> java.time.temporal.WeekFields.ISO is instantiated using the constructor,
> which is a different object returned from WeekFields.of(MONDAY, 4). Even
> though this itself does not cause any issues, since objects are "equal",
> but the fix will provide the identity, as WeekFields objects are
> supposed to be singletons.
>
> Naoto
>

RFR 8233048: WeekFields.ISO is not a singleton

2020-07-30 Thread naoto . sato 

Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8233048

The proposed chageset is located at:

https://cr.openjdk.java.net/~naoto/8233048/webrev.00/

java.time.temporal.WeekFields.ISO is instantiated using the constructor, 
which is a different object returned from WeekFields.of(MONDAY, 4). Even 
though this itself does not cause any issues, since objects are "equal", 
but the fix will provide the identity, as WeekFields objects are 
supposed to be singletons.


Naoto