Re: RFR 8242931: Few more tests that use nashorn have been missed
Hi Sundar, On 17/04/2020 4:00 am, sundararajan.athijegannat...@oracle.com wrote: Thanks Daniel. Fixed it. Updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.02/ These changes seem okay in themselves. Thanks, David PS. Submitting mach5 job concurrently. Thanks, -Sundar On 16/04/20 11:16 pm, Daniel Fuchs wrote: Hi Sundar, I spotted a typo (generial vs generic) test/jdk/ProblemList.txt: 936 java/util/ServiceLoader/ReloadTest.java 8242935 generial-all This is not an area I know well - so maybe wait for at least another opinion (reviewer or not) but what I saw looked reasonable. You have my review. best regards, -- daniel On 16/04/2020 17:26, sundararajan.athijegannat...@oracle.com wrote: Please review updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.01/ Thanks, -Sundar On 16/04/20 6:49 pm, David Holmes wrote: +1 Please problem list the tests under the associated bug ids. Thanks, David On 16/04/2020 11:10 pm, Alan Bateman wrote: On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
Re: RFR 8242931: Few more tests that use nashorn have been missed
On 16/04/2020 19:00, sundararajan.athijegannat...@oracle.com wrote: Thanks Daniel. Fixed it. Updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.02/ LGTM best regards, -- daniel PS. Submitting mach5 job concurrently. Thanks, -Sundar
Re: RFR 8242931: Few more tests that use nashorn have been missed
Thanks Daniel. Fixed it. Updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.02/ PS. Submitting mach5 job concurrently. Thanks, -Sundar On 16/04/20 11:16 pm, Daniel Fuchs wrote: Hi Sundar, I spotted a typo (generial vs generic) test/jdk/ProblemList.txt: 936 java/util/ServiceLoader/ReloadTest.java 8242935 generial-all This is not an area I know well - so maybe wait for at least another opinion (reviewer or not) but what I saw looked reasonable. You have my review. best regards, -- daniel On 16/04/2020 17:26, sundararajan.athijegannat...@oracle.com wrote: Please review updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.01/ Thanks, -Sundar On 16/04/20 6:49 pm, David Holmes wrote: +1 Please problem list the tests under the associated bug ids. Thanks, David On 16/04/2020 11:10 pm, Alan Bateman wrote: On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
Re: RFR 8242931: Few more tests that use nashorn have been missed
Hi Sundar, I spotted a typo (generial vs generic) test/jdk/ProblemList.txt: 936 java/util/ServiceLoader/ReloadTest.java 8242935 generial-all This is not an area I know well - so maybe wait for at least another opinion (reviewer or not) but what I saw looked reasonable. You have my review. best regards, -- daniel On 16/04/2020 17:26, sundararajan.athijegannat...@oracle.com wrote: Please review updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.01/ Thanks, -Sundar On 16/04/20 6:49 pm, David Holmes wrote: +1 Please problem list the tests under the associated bug ids. Thanks, David On 16/04/2020 11:10 pm, Alan Bateman wrote: On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
Re: RFR 8242931: Few more tests that use nashorn have been missed
Please review updated webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.01/ Thanks, -Sundar On 16/04/20 6:49 pm, David Holmes wrote: +1 Please problem list the tests under the associated bug ids. Thanks, David On 16/04/2020 11:10 pm, Alan Bateman wrote: On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
Re: RFR 8242931: Few more tests that use nashorn have been missed
Hi Sundar, Will there be a replacement for Nashorn, i.e. V8 with added Java bindings? I am asking because one of the JFR test uses Nashorn for parsing JSON and if another parser is coming in the near future, it could be used. instead of adding a parser for the test. Thanks Erik > On 16 Apr 2020, at 14:59, sundararajan.athijegannat...@oracle.com wrote: > > Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) > missed updating few tests, config files. > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 > > Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ > > PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. > Please revisit port or remove these nashorn using tests > > Thanks, > > -Sundar >
Re: RFR 8242931: Few more tests that use nashorn have been missed
+1 Please problem list the tests under the associated bug ids. Thanks, David On 16/04/2020 11:10 pm, Alan Bateman wrote: On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
Re: RFR 8242931: Few more tests that use nashorn have been missed
On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote: Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Can you use the jtreg exclude lists (ProblemList.txt files) instead? We moved away from @ignore a few ago to make it easier to track excluded tests. -Alan
RFR 8242931: Few more tests that use nashorn have been missed
Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript Engine) missed updating few tests, config files. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242931 Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/ PS I'm disabling tests by adding @ignore. I've filed bugs for the tests. Please revisit port or remove these nashorn using tests Thanks, -Sundar
