os.name will be "macOS"? (was Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac)

[Wang Weijun]

I have an off-topic question:

Will os.name be macOS for 10.12? I have several places checking "if 
(!osname.contains("OS X"))", is there a helper method I can check for this in 
the future no matter if it's running on pre- or post-10.12?

Thanks
Max

> On Jul 1, 2016, at 2:23 AM, Brent Christian  
> wrote:
> 
> On 6/30/16 9:53 AM, Brent Christian wrote:
>> 
>> When the minimum Mac build platform is SDK 10.10, we'll be able to call
>> operatingSystemVersion directly without using msgSend.  We can also
>> consider removing this then.
> 
> FYI:
> https://bugs.openjdk.java.net/browse/JDK-8160676
> 
> -Brent

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

On 6/30/16 9:53 AM, Brent Christian wrote:


When the minimum Mac build platform is SDK 10.10, we'll be able to call
operatingSystemVersion directly without using msgSend.  We can also
consider removing this then.


FYI:
https://bugs.openjdk.java.net/browse/JDK-8160676

-Brent

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Mandy Chung]

> On Jun 30, 2016, at 7:33 AM, Gerard Ziemski  wrote:
> 
> 
>> On Jun 29, 2016, at 6:47 PM, Mandy Chung  wrote:
>> 
>> I think we should move away from testing on unsupported platforms.  Is this 
>> just temporary?  when will this be removed?
> 
> I think we should leave the workaround code in forever - it will never 
> execute on newer/supported OS X and will do the right thing on earlier ones.

I disagree to leave dead code in our source forever (imagine the amount of code 
that we removed in the past were left in the source base).

It may be fine to add this temporarily until our infrastructure completes 
migrating to supported platforms.  We should track this and remove it in the 
future.

Mandy

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

On 6/29/16 4:47 PM, Mandy Chung wrote:

On Jun 29, 2016, at 12:36 PM, Brent Christian  
wrote:

The code to restore behavior on older Mac systems is only a few
lines, so that seems like a good way to get testing going again.


I think we should move away from testing on unsupported platforms.
Is this just temporary?  when will this be removed?


When the minimum Mac build platform is SDK 10.10, we'll be able to call 
operatingSystemVersion directly without using msgSend.  We can also 
consider removing this then.


Thanks,
-Brent

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

Thanks, Brian

On 6/29/16 4:35 PM, Brian Burkhalter wrote:

Approved.

Brian

On Jun 29, 2016, at 4:33 PM, Brent Christian > wrote:


Thank you, Dave and Gerard.
I believe I still need to hear from a JDK9 Reviewer.

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

Will do - thanks, Roger.

-Brent

On 6/30/16 6:46 AM, Roger Riggs wrote:

+1

Can you wrap a couple of very long lines to make the diff easier to read.
- 187
- 202

Thanks, Roger


On 6/29/2016 7:47 PM, Mandy Chung wrote:

On Jun 29, 2016, at 12:36 PM, Brent Christian
 wrote:

Hi,

Please review the following change for JDK 9:

Bug:
https://bugs.openjdk.java.net/browse/JDK-8160370
Webrev:
http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/

The fix for 7131356 fills in the "os.version" system property on Mac
using [NSProcessInfo operatingSystemVersion], available starting in
Mac OS 10.9.

While JDK 9 will not support versions of Mac OS prior to 10.9 [1],
not all testing infrastructure has been updated, and we've seen
failures of

java/lang/System/OsVersionTest.java

The code to restore behavior on older Mac systems is only a few
lines, so that seems like a good way to get testing going again.

I think we should move away from testing on unsupported platforms.  Is
this just temporary?  when will this be removed?

Mandy

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Gerard Ziemski]

> On Jun 29, 2016, at 6:47 PM, Mandy Chung  wrote:
> 
>> 
>> On Jun 29, 2016, at 12:36 PM, Brent Christian  
>> wrote:
>> 
>> Hi,
>> 
>> Please review the following change for JDK 9:
>> 
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8160370
>> Webrev:
>> http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/
>> 
>> The fix for 7131356 fills in the "os.version" system property on Mac using 
>> [NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.
>> 
>> While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
>> testing infrastructure has been updated, and we've seen failures of
>> 
>> java/lang/System/OsVersionTest.java
>> 
>> The code to restore behavior on older Mac systems is only a few lines, so 
>> that seems like a good way to get testing going again.
> 
> I think we should move away from testing on unsupported platforms.  Is this 
> just temporary?  when will this be removed?

I think we should leave the workaround code in forever - it will never execute 
on newer/supported OS X and will do the right thing on earlier ones.


cheers

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Roger Riggs]

+1

Can you wrap a couple of very long lines to make the diff easier to read.
- 187
- 202

Thanks, Roger


On 6/29/2016 7:47 PM, Mandy Chung wrote:

On Jun 29, 2016, at 12:36 PM, Brent Christian  
wrote:

Hi,

Please review the following change for JDK 9:

Bug:
https://bugs.openjdk.java.net/browse/JDK-8160370
Webrev:
http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/

The fix for 7131356 fills in the "os.version" system property on Mac using 
[NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.

While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
testing infrastructure has been updated, and we've seen failures of

java/lang/System/OsVersionTest.java

The code to restore behavior on older Mac systems is only a few lines, so that 
seems like a good way to get testing going again.

I think we should move away from testing on unsupported platforms.  Is this 
just temporary?  when will this be removed?

Mandy

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Mandy Chung]

> On Jun 29, 2016, at 12:36 PM, Brent Christian  
> wrote:
> 
> Hi,
> 
> Please review the following change for JDK 9:
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8160370
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/
> 
> The fix for 7131356 fills in the "os.version" system property on Mac using 
> [NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.
> 
> While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
> testing infrastructure has been updated, and we've seen failures of
> 
> java/lang/System/OsVersionTest.java
> 
> The code to restore behavior on older Mac systems is only a few lines, so 
> that seems like a good way to get testing going again.

I think we should move away from testing on unsupported platforms.  Is this 
just temporary?  when will this be removed?

Mandy

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brian Burkhalter]

Approved.

Brian

On Jun 29, 2016, at 4:33 PM, Brent Christian  wrote:

> Thank you, Dave and Gerard.
> I believe I still need to hear from a JDK9 Reviewer.

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

Thank you, Dave and Gerard.
I believe I still need to hear from a JDK9 Reviewer.

Thanks,
-Brent
On 06/29/2016 01:08 PM, David DeHaven wrote:


Fix looks good to me too.

-DrD-


On Jun 29, 2016, at 12:54 PM, Gerard Ziemski  wrote:

hi Brent,

Thank you for fixing the original issue and for putting in this follow-up fix!

Looks good! (for full disclosure I proposed the workaround)


cheers


On Jun 29, 2016, at 2:36 PM, Brent Christian  wrote:

Hi,

Please review the following change for JDK 9:

Bug:
https://bugs.openjdk.java.net/browse/JDK-8160370
Webrev:
http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/

The fix for 7131356 fills in the "os.version" system property on Mac using 
[NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.

While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
testing infrastructure has been updated, and we've seen failures of

java/lang/System/OsVersionTest.java

The code to restore behavior on older Mac systems is only a few lines, so that 
seems like a good way to get testing going again.

Thanks,
-Brent

1. https://jdk9.java.net/jdk9_supported_platforms.html
2. https://bugs.openjdk.java.net/browse/JDK-8156132

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[David DeHaven]

Fix looks good to me too.

-DrD-

> On Jun 29, 2016, at 12:54 PM, Gerard Ziemski  
> wrote:
> 
> hi Brent,
> 
> Thank you for fixing the original issue and for putting in this follow-up fix!
> 
> Looks good! (for full disclosure I proposed the workaround)
> 
> 
> cheers
> 
>> On Jun 29, 2016, at 2:36 PM, Brent Christian  
>> wrote:
>> 
>> Hi,
>> 
>> Please review the following change for JDK 9:
>> 
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8160370
>> Webrev:
>> http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/
>> 
>> The fix for 7131356 fills in the "os.version" system property on Mac using 
>> [NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.
>> 
>> While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
>> testing infrastructure has been updated, and we've seen failures of
>> 
>> java/lang/System/OsVersionTest.java
>> 
>> The code to restore behavior on older Mac systems is only a few lines, so 
>> that seems like a good way to get testing going again.
>> 
>> Thanks,
>> -Brent
>> 
>> 1. https://jdk9.java.net/jdk9_supported_platforms.html
>> 2. https://bugs.openjdk.java.net/browse/JDK-8156132
> 

Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Gerard Ziemski]

hi Brent,

Thank you for fixing the original issue and for putting in this follow-up fix!

Looks good! (for full disclosure I proposed the workaround)


cheers

> On Jun 29, 2016, at 2:36 PM, Brent Christian  
> wrote:
> 
> Hi,
> 
> Please review the following change for JDK 9:
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8160370
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/
> 
> The fix for 7131356 fills in the "os.version" system property on Mac using 
> [NSProcessInfo operatingSystemVersion], available starting in Mac OS 10.9.
> 
> While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not all 
> testing infrastructure has been updated, and we've seen failures of
> 
> java/lang/System/OsVersionTest.java
> 
> The code to restore behavior on older Mac systems is only a few lines, so 
> that seems like a good way to get testing going again.
> 
> Thanks,
> -Brent
> 
> 1. https://jdk9.java.net/jdk9_supported_platforms.html
> 2. https://bugs.openjdk.java.net/browse/JDK-8156132

RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac

[Brent Christian]

Hi,

Please review the following change for JDK 9:

Bug:
https://bugs.openjdk.java.net/browse/JDK-8160370
Webrev:
http://cr.openjdk.java.net/~bchristi/8160370/webrev.00/

The fix for 7131356 fills in the "os.version" system property on Mac 
using [NSProcessInfo operatingSystemVersion], available starting in Mac 
OS 10.9.


While JDK 9 will not support versions of Mac OS prior to 10.9 [1], not 
all testing infrastructure has been updated, and we've seen failures of


java/lang/System/OsVersionTest.java

The code to restore behavior on older Mac systems is only a few lines, 
so that seems like a good way to get testing going again.


Thanks,
-Brent

1. https://jdk9.java.net/jdk9_supported_platforms.html
2. https://bugs.openjdk.java.net/browse/JDK-8156132