Re: RFR JDK-8080252: java.util.Formatter documentation of %n converter is misleading

2015-07-30 Thread Stuart Marks

Hi Sherman,

The change looks fine to me.

s'marks

On 7/30/15 10:34 AM, Xueming Shen wrote:

Hi,

Please help review the change for

issue: https://bugs.openjdk.java.net/browse/JDK-8080252
webrev: http://cr.openjdk.java.net/~sherman/8080252/

It appears we updated the j.u.Formatter implementation to use the newly 
introduced
method System.lineSeparator() in jdk7, but did not update the doc accordingly.

For the old the behavior, I would assume the initial intent is to treat the
system property
line.separator as a read-only/informative property.

Given the fact the it has been 2 major releases (7, 8), I would assume this
change is now
a kind of change to update the javadoc to describe the existing implementation
correctly.
So a CCC is not needed.

Thanks,
Sherman




RFR JDK-8080252: java.util.Formatter documentation of %n converter is misleading

2015-07-30 Thread Xueming Shen

Hi,

Please help review the change for

issue: https://bugs.openjdk.java.net/browse/JDK-8080252
webrev: http://cr.openjdk.java.net/~sherman/8080252/

It appears we updated the j.u.Formatter implementation to use the newly 
introduced
method System.lineSeparator() in jdk7, but did not update the doc 
accordingly.


For the old the behavior, I would assume the initial intent is to treat 
the system property

line.separator as a read-only/informative property.

Given the fact the it has been 2 major releases (7, 8), I would assume 
this change is now
a kind of change to update the javadoc to describe the existing 
implementation correctly.

So a CCC is not needed.

Thanks,
Sherman