Re: RFR JDK-8213909: jdeps --print-module-deps should report missing dependences
Hi Mandy, Delta webrev looks good. -Sundar On 21/11/18, 2:12 AM, Mandy Chung wrote: Hi Sundar, Per Joe's feedback on this CSR, a new `--no-recursive` option is added to restore the non-transitive behavior. Here is the delta webrev: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.01-delta Thanks Mandy On 11/19/18 9:22 AM, Mandy Chung wrote: Thanks Sundar. Here is the CSR: https://bugs.openjdk.java.net/browse/JDK-8213915 Mandy On 11/19/18 6:48 AM, Sundararajan Athijegannathan wrote: Looks good to me. -Sundar On 15/11/18, 5:46 AM, Mandy Chung wrote: This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-module-deps app.jar `--print-module-deps` finds the modules required by the specified application. Its result can be used to create a runtime image for such application to run. The current behavior does not report missing dependences. In addition, `--print-module-deps` only reports module dependences required by app.jar. To include the transitive module dependences required by libs, if referenced, -R option can be used. If -R option is not specified, app.jar will fail to run on the runtime image created by the output from `jdeps --print-module-deps`. The patch changes the default behavior to do transitive analysis. In addition, it will report as an error if any dependence is missing and not found. The --ignore-missing-deps option can be used to ignore missing deps. This patch also includes a simple fix in JdepsTask.ResourceBundleHelper for: JDK-8168869: jdeps: localized messages don't use proper line breaks I can separate it in its own changeset when I push. Thanks Mandy
Re: RFR JDK-8213909: jdeps --print-module-deps should report missing dependences
Hi Sundar, Per Joe's feedback on this CSR, a new `--no-recursive` option is added to restore the non-transitive behavior. Here is the delta webrev: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.01-delta Thanks Mandy On 11/19/18 9:22 AM, Mandy Chung wrote: Thanks Sundar. Here is the CSR: https://bugs.openjdk.java.net/browse/JDK-8213915 Mandy On 11/19/18 6:48 AM, Sundararajan Athijegannathan wrote: Looks good to me. -Sundar On 15/11/18, 5:46 AM, Mandy Chung wrote: This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-module-deps app.jar `--print-module-deps` finds the modules required by the specified application. Its result can be used to create a runtime image for such application to run. The current behavior does not report missing dependences. In addition, `--print-module-deps` only reports module dependences required by app.jar. To include the transitive module dependences required by libs, if referenced, -R option can be used. If -R option is not specified, app.jar will fail to run on the runtime image created by the output from `jdeps --print-module-deps`. The patch changes the default behavior to do transitive analysis. In addition, it will report as an error if any dependence is missing and not found. The --ignore-missing-deps option can be used to ignore missing deps. This patch also includes a simple fix in JdepsTask.ResourceBundleHelper for: JDK-8168869: jdeps: localized messages don't use proper line breaks I can separate it in its own changeset when I push. Thanks Mandy
Re: RFR JDK-8213909: jdeps --print-module-deps should report missing dependences
Thanks Sundar. Here is the CSR: https://bugs.openjdk.java.net/browse/JDK-8213915 Mandy On 11/19/18 6:48 AM, Sundararajan Athijegannathan wrote: Looks good to me. -Sundar On 15/11/18, 5:46 AM, Mandy Chung wrote: This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-module-deps app.jar `--print-module-deps` finds the modules required by the specified application. Its result can be used to create a runtime image for such application to run. The current behavior does not report missing dependences. In addition, `--print-module-deps` only reports module dependences required by app.jar. To include the transitive module dependences required by libs, if referenced, -R option can be used. If -R option is not specified, app.jar will fail to run on the runtime image created by the output from `jdeps --print-module-deps`. The patch changes the default behavior to do transitive analysis. In addition, it will report as an error if any dependence is missing and not found. The --ignore-missing-deps option can be used to ignore missing deps. This patch also includes a simple fix in JdepsTask.ResourceBundleHelper for: JDK-8168869: jdeps: localized messages don't use proper line breaks I can separate it in its own changeset when I push. Thanks Mandy
Re: RFR JDK-8213909: jdeps --print-module-deps should report missing dependences
Looks good to me. -Sundar On 15/11/18, 5:46 AM, Mandy Chung wrote: This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-module-deps app.jar `--print-module-deps` finds the modules required by the specified application. Its result can be used to create a runtime image for such application to run. The current behavior does not report missing dependences. In addition, `--print-module-deps` only reports module dependences required by app.jar. To include the transitive module dependences required by libs, if referenced, -R option can be used. If -R option is not specified, app.jar will fail to run on the runtime image created by the output from `jdeps --print-module-deps`. The patch changes the default behavior to do transitive analysis. In addition, it will report as an error if any dependence is missing and not found. The --ignore-missing-deps option can be used to ignore missing deps. This patch also includes a simple fix in JdepsTask.ResourceBundleHelper for: JDK-8168869: jdeps: localized messages don't use proper line breaks I can separate it in its own changeset when I push. Thanks Mandy
RFR JDK-8213909: jdeps --print-module-deps should report missing dependences
This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-module-deps app.jar `--print-module-deps` finds the modules required by the specified application. Its result can be used to create a runtime image for such application to run. The current behavior does not report missing dependences. In addition, `--print-module-deps` only reports module dependences required by app.jar. To include the transitive module dependences required by libs, if referenced, -R option can be used. If -R option is not specified, app.jar will fail to run on the runtime image created by the output from `jdeps --print-module-deps`. The patch changes the default behavior to do transitive analysis. In addition, it will report as an error if any dependence is missing and not found. The --ignore-missing-deps option can be used to ignore missing deps. This patch also includes a simple fix in JdepsTask.ResourceBundleHelper for: JDK-8168869: jdeps: localized messages don't use proper line breaks I can separate it in its own changeset when I push. Thanks Mandy
