Re: RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module
Hi Jon,
Looks good to me.
Thanks,
Serguei
On 6/4/19 2:42 PM, Jonathan Gibbons wrote:
Please review another small patch for the jdk.jdi module, to fix a
missing heading in one file and to adjust a heading in another.
No webrev; patch below.
That being said, the file
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely
warrants being its own file, but even what content there is deserves
to be fixed. The table caption is oversized, the table has no borders
and not not use any CSS to "stripe" the rows. However, that cleanup is
out of scope for this accessibility fix for the headings.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8225309
$ hg diff -R open
diff -r 4158e6a864d4
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
Tue Jun 04 13:47:59 2019 -0700
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
Tue Jun 04 14:35:34 2019 -0700
@@ -41,6 +41,7 @@
+JDI Type Signatures
JDI Type Signatures
diff -r 4158e6a864d4 src/jdk.jdi/share/classes/module-info.java
--- a/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 13:47:59
2019 -0700
+++ b/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 14:35:34
2019 -0700
@@ -46,7 +46,7 @@
* This module includes a simple command-line debugger,
* {@index jdb jdb tool}.
*
- * Global Exceptions
+ * Global Exceptions
*
* This section documents exceptions which apply to the entire API
and are thus
* not documented on individual methods.
Re: RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module
+1
> On Jun 4, 2019, at 5:42 PM, Jonathan Gibbons
> wrote:
>
> Please review another small patch for the jdk.jdi module, to fix a missing
> heading in one file and to adjust a heading in another.
>
> No webrev; patch below.
>
> That being said, the file
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely
> warrants being its own file, but even what content there is deserves to be
> fixed. The table caption is oversized, the table has no borders and not not
> use any CSS to "stripe" the rows. However, that cleanup is out of scope for
> this accessibility fix for the headings.
>
> -- Jon
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8225309
>
>
> $ hg diff -R open
> diff -r 4158e6a864d4
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
> --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue Jun
> 04 13:47:59 2019 -0700
> +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue Jun
> 04 14:35:34 2019 -0700
> @@ -41,6 +41,7 @@
>
>
>
> +JDI Type Signatures
>
> JDI Type Signatures
>
> diff -r 4158e6a864d4 src/jdk.jdi/share/classes/module-info.java
> --- a/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 13:47:59 2019
> -0700
> +++ b/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 14:35:34 2019
> -0700
> @@ -46,7 +46,7 @@
> * This module includes a simple command-line debugger,
> * {@index jdb jdb tool}.
> *
> - * Global Exceptions
> + * Global Exceptions
> *
> * This section documents exceptions which apply to the entire API and are
> thus
> * not documented on individual methods.
>
Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module
Please review another small patch for the jdk.jdi module, to fix a
missing heading in one file and to adjust a heading in another.
No webrev; patch below.
That being said, the file
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely
warrants being its own file, but even what content there is deserves to
be fixed. The table caption is oversized, the table has no borders and
not not use any CSS to "stripe" the rows. However, that cleanup is out
of scope for this accessibility fix for the headings.
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8225309
$ hg diff -R open
diff -r 4158e6a864d4
src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
--- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue
Jun 04 13:47:59 2019 -0700
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue
Jun 04 14:35:34 2019 -0700
@@ -41,6 +41,7 @@
+JDI Type Signatures
JDI Type Signatures
diff -r 4158e6a864d4 src/jdk.jdi/share/classes/module-info.java
--- a/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 13:47:59
2019 -0700
+++ b/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 14:35:34
2019 -0700
@@ -46,7 +46,7 @@
* This module includes a simple command-line debugger,
* {@index jdb jdb tool}.
*
- * Global Exceptions
+ * Global Exceptions
*
* This section documents exceptions which apply to the entire API and
are thus
* not documented on individual methods.
