Re: 8006344: Broken javadoc link in javax.lang.model.element.Element

2013-01-15 Thread Lance Andersen - Oracle 
+1
On Jan 15, 2013, at 12:59 PM, Chris Hegarty wrote:

 Minor oversight in the changes from 7193719: Support repeating annotations 
 in javax.lang.model.
 
 ~/repos/jdk8/tl/adder/build/solaris-i586/impsrc/javax/lang/model/element/Element.java:199:
  warning - Tag @see: can't find getAnnotation() in 
 javax.lang.model.element.Element
 
 I only noticed when building javadocs for another issue, thankfully we don't 
 have many warnings here ;-)
 
 
 diff -r d54b4a091450 src/share/classes/javax/lang/model/element/Element.java
 --- a/src/share/classes/javax/lang/model/element/Element.java   Mon Jan 14 
 14:17:25 2013 -0800
 +++ b/src/share/classes/javax/lang/model/element/Element.java   Tue Jan 15 
 17:55:17 2013 +
 @@ -188,7 +188,7 @@ public interface Element {
  * type if present on this element, else an empty array
  *
  * @see #getAnnotationMirrors()
 - * @see #getAnnotation()
 + * @see #getAnnotation(java.lang.Class)
  * @see java.lang.reflect.AnnotatedElement#getAnnotations
  * @see EnumConstantNotPresentException
  * @see AnnotationTypeMismatchException
 
 -Chris.


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: 8006344: Broken javadoc link in javax.lang.model.element.Element

2013-01-15 Thread Alan Bateman 

On 15/01/2013 17:59, Chris Hegarty wrote:
Minor oversight in the changes from 7193719: Support repeating 
annotations in javax.lang.model.


~/repos/jdk8/tl/adder/build/solaris-i586/impsrc/javax/lang/model/element/Element.java:199: 
warning - Tag @see: can't find getAnnotation() in 
javax.lang.model.element.Element


I only noticed when building javadocs for another issue, thankfully we 
don't have many warnings here ;-)



diff -r d54b4a091450 
src/share/classes/javax/lang/model/element/Element.java
--- a/src/share/classes/javax/lang/model/element/Element.java   Mon 
Jan 14 14:17:25 2013 -0800
+++ b/src/share/classes/javax/lang/model/element/Element.java   Tue 
Jan 15 17:55:17 2013 +

@@ -188,7 +188,7 @@ public interface Element {
  * type if present on this element, else an empty array
  *
  * @see #getAnnotationMirrors()
- * @see #getAnnotation()
+ * @see #getAnnotation(java.lang.Class)
  * @see java.lang.reflect.AnnotatedElement#getAnnotations
  * @see EnumConstantNotPresentException
  * @see AnnotationTypeMismatchException

-Chris.

Looks good to me too.

-Alan

Re: 8006344: Broken javadoc link in javax.lang.model.element.Element

2013-01-15 Thread Joel Borggrén-Franck 
Thanks for catching this,

Looks good.

cheers
/Joel

On 15 jan 2013, at 18:59, Chris Hegarty chris.hega...@oracle.com wrote:

 Minor oversight in the changes from 7193719: Support repeating annotations 
 in javax.lang.model.
 
 ~/repos/jdk8/tl/adder/build/solaris-i586/impsrc/javax/lang/model/element/Element.java:199:
  warning - Tag @see: can't find getAnnotation() in 
 javax.lang.model.element.Element
 
 I only noticed when building javadocs for another issue, thankfully we don't 
 have many warnings here ;-)
 
 
 diff -r d54b4a091450 src/share/classes/javax/lang/model/element/Element.java
 --- a/src/share/classes/javax/lang/model/element/Element.java   Mon Jan 14 
 14:17:25 2013 -0800
 +++ b/src/share/classes/javax/lang/model/element/Element.java   Tue Jan 15 
 17:55:17 2013 +
 @@ -188,7 +188,7 @@ public interface Element {
  * type if present on this element, else an empty array
  *
  * @see #getAnnotationMirrors()
 - * @see #getAnnotation()
 + * @see #getAnnotation(java.lang.Class)
  * @see java.lang.reflect.AnnotatedElement#getAnnotations
  * @see EnumConstantNotPresentException
  * @see AnnotationTypeMismatchException
 
 -Chris.