Re: JDK-8229786: No output after WinShortcutTest.exe is launched
Looks good. Thanks, Alexander On 8/16/2019 12:12 PM, Alexey Semenyuk wrote: Makes sense. Looks good then. - Alexey On 8/16/2019 3:08 PM, Andy Herrick wrote: On 8/16/2019 2:26 PM, Alexey Semenyuk wrote: Andy, I think we want this change in all Windows jtreg tests as they all use this windowless Hello test. yes - but except for testing launching app from shortcut of the installed app, the automated tests run the app and capture it's output, so only on these cases is--win-console arg needed to confirm the operation (creation of a shortcut by installer) succeeded. /Andy - Alexey On 8/16/2019 2:22 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229786 [2] http://cr.openjdk.java.net/~herrick/8229786 Thanks, Andy
Re: JDK-8229786: No output after WinShortcutTest.exe is launched
Makes sense. Looks good then. - Alexey On 8/16/2019 3:08 PM, Andy Herrick wrote: On 8/16/2019 2:26 PM, Alexey Semenyuk wrote: Andy, I think we want this change in all Windows jtreg tests as they all use this windowless Hello test. yes - but except for testing launching app from shortcut of the installed app, the automated tests run the app and capture it's output, so only on these cases is--win-console arg needed to confirm the operation (creation of a shortcut by installer) succeeded. /Andy - Alexey On 8/16/2019 2:22 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229786 [2] http://cr.openjdk.java.net/~herrick/8229786 Thanks, Andy
Re: JDK-8229786: No output after WinShortcutTest.exe is launched
On 8/16/2019 2:26 PM, Alexey Semenyuk wrote: Andy, I think we want this change in all Windows jtreg tests as they all use this windowless Hello test. yes - but except for testing launching app from shortcut of the installed app, the automated tests run the app and capture it's output, so only on these cases is--win-console arg needed to confirm the operation (creation of a shortcut by installer) succeeded. /Andy - Alexey On 8/16/2019 2:22 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229786 [2] http://cr.openjdk.java.net/~herrick/8229786 Thanks, Andy
Re: JDK-8229786: No output after WinShortcutTest.exe is launched
Andy, I think we want this change in all Windows jtreg tests as they all use this windowless Hello test. - Alexey On 8/16/2019 2:22 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229786 [2] http://cr.openjdk.java.net/~herrick/8229786 Thanks, Andy
