Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

2020-04-29 Thread Igor Ignatyev 
Serguei, David,

thanks for your reviews. pushed.

-- Igor

> On Apr 28, 2020, at 11:39 PM, serguei.spit...@oracle.com wrote:
> 
> LGTM++
> 
> Thanks,
> Serguei
> 
> 
> On 4/28/20 23:28, David Holmes wrote:
>> Looks good!
>> 
>> Thanks,
>> David
>> 
>> On 29/04/2020 1:20 pm, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
 34 lines changed: 0 ins; 11 del; 23 mod;
>>> 
>>> Hi all,
>>> 
>>> could you please review this trivial patch?
>>> from JBS:
 JDK-8199290 made it unnecessary to explicitly pass 
 sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to 
 ClassFileInstaller b/c the former now copies it every time it copies 
 sun.hotspot.WhiteBox.
>>> 
>>> besides removing WhiteBoxPermission from the list of ClassFileInstaller's 
>>> arguments, the patch also makes sure ClassFileInstaller is run in a driver 
>>> mode in all the touched tests.
>>> 
>>> testing: the changed tests
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244052
>>> 
>>> Thanks,
>>> -- Igor
>>> 
>

Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

2020-04-29 Thread serguei.spit...@oracle.com 

LGTM++

Thanks,
Serguei


On 4/28/20 23:28, David Holmes wrote:

Looks good!

Thanks,
David

On 29/04/2020 1:20 pm, Igor Ignatyev wrote:

http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/

34 lines changed: 0 ins; 11 del; 23 mod;


Hi all,

could you please review this trivial patch?
from JBS:
JDK-8199290 made it unnecessary to explicitly pass 
sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to 
ClassFileInstaller b/c the former now copies it every time it copies 
sun.hotspot.WhiteBox.


besides removing WhiteBoxPermission from the list of 
ClassFileInstaller's arguments, the patch also makes sure 
ClassFileInstaller is run in a driver mode in all the touched tests.


testing: the changed tests
webrev: http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8244052

Thanks,
-- Igor

Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

2020-04-29 Thread David Holmes 

Looks good!

Thanks,
David

On 29/04/2020 1:20 pm, Igor Ignatyev wrote:

http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/

34 lines changed: 0 ins; 11 del; 23 mod;


Hi all,

could you please review this trivial patch?
from JBS:

JDK-8199290 made it unnecessary to explicitly pass 
sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to ClassFileInstaller 
b/c the former now copies it every time it copies sun.hotspot.WhiteBox.


besides removing WhiteBoxPermission from the list of ClassFileInstaller's 
arguments, the patch also makes sure ClassFileInstaller is run in a driver mode 
in all the touched tests.

testing: the changed tests
webrev: http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8244052

Thanks,
-- Igor