Re: RFR: 8075806: divideExact is missing in java.lang.Math [v2]
On Wed, 14 Jul 2021 16:43:32 GMT, Joe Darcy wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8075806: Separate div-by-0 verbiage; change impl
>
> src/java.base/share/classes/java/lang/Math.java line 1008:
>
>> 1006: * Returns the quotient of the arguments, throwing an exception if
>> the
>> 1007: * result overflows an {@code int}. Such overflow can occur if
>> and only
>> 1008: * if either {@code y} is zero, or both {@code x} is
>
> I think the divide by zero case should be discussed separately from overflow.
Fixed.
-
PR: https://git.openjdk.java.net/jdk/pull/4770
Re: RFR: 8075806: divideExact is missing in java.lang.Math [v2]
> Please consider this proposal to add `divideExact()` methods for integral > data types to `java.lang.Math` thereby rounding out "exact" support to all > four basic arithmetic operations. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8075806: Separate div-by-0 verbiage; change impl - Changes: - all: https://git.openjdk.java.net/jdk/pull/4770/files - new: https://git.openjdk.java.net/jdk/pull/4770/files/db216a6d..6843e666 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4770=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4770=00-01 Stats: 29 lines in 1 file changed: 8 ins; 3 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/4770.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4770/head:pull/4770 PR: https://git.openjdk.java.net/jdk/pull/4770
