Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]
On Thu, 25 Nov 2021 08:26:56 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Replaced integer literals.
>> - Refined wording #2
>
> src/java.base/share/classes/java/time/format/DateTimeFormatter.java line 508:
>
>> 506: * of {@link ChronoLocalDateTime#atZone(ZoneId)}. If the {@code ZoneId}
>> was
>> 507: * parsed from the zone name that does not indicate daylight saving
>> time, then
>> 508: * the standard offset will be used at the local time-line overlap.
>
> As written, I would read it as being the generic zone name that gets altered,
> rather than a zone name that explicitly indicates "winter" time. maybe:
>
> "If the {@code ZoneId} was parsed from a zone name that indicates whether
> daylight saving time in in operation or not, then that fact will be used to
> select the correct offset at the local time-line overlap."
Modified as suggested.
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
> line 4906:
>
>> 4904: private static class LENIENT extends CI {
>> 4905:
>> 4906: private LENIENT(String k, String v, int t, PrefixTree
>> child) {
>
> Is class `LENIENT` actually in use?
Removed.
-
PR: https://git.openjdk.java.net/jdk/pull/6527
Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Replaced integer literals.
> - Refined wording #2
src/java.base/share/classes/java/time/format/DateTimeFormatter.java line 508:
> 506: * of {@link ChronoLocalDateTime#atZone(ZoneId)}. If the {@code ZoneId}
> was
> 507: * parsed from the zone name that does not indicate daylight saving
> time, then
> 508: * the standard offset will be used at the local time-line overlap.
As written, I would read it as being the generic zone name that gets altered,
rather than a zone name that explicitly indicates "winter" time. maybe:
"If the {@code ZoneId} was parsed from a zone name that indicates whether
daylight saving time in in operation or not, then that fact will be used to
select the correct offset at the local time-line overlap."
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line
4906:
> 4904: private static class LENIENT extends CI {
> 4905:
> 4906: private LENIENT(String k, String v, int t, PrefixTree
> child) {
Is class `LENIENT` actually in use?
-
PR: https://git.openjdk.java.net/jdk/pull/6527
Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote: >> This fix intends to honor the type (std/dst/generic) of parsed zone name for >> selecting the offset at the overlap. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with two additional > commits since the last revision: > > - Replaced integer literals. > - Refined wording #2 Thanks Naoto. The change Look good to me. - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6527
Re: RFR: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST [v3]
> This fix intends to honor the type (std/dst/generic) of parsed zone name for > selecting the offset at the overlap. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with two additional commits since the last revision: - Replaced integer literals. - Refined wording #2 - Changes: - all: https://git.openjdk.java.net/jdk/pull/6527/files - new: https://git.openjdk.java.net/jdk/pull/6527/files/99ad3cad..89c894ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6527&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6527&range=01-02 Stats: 18 lines in 4 files changed: 2 ins; 1 del; 15 mod Patch: https://git.openjdk.java.net/jdk/pull/6527.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6527/head:pull/6527 PR: https://git.openjdk.java.net/jdk/pull/6527
