Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Brian Burkhalter 
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves  wrote:

>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rewording repetitive phrase

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Lance Andersen 
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves  wrote:

>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rewording repetitive phrase

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Iris Clark 
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves  wrote:

>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rewording repetitive phrase

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-21 Thread Ian Graves 
> 8199594: Add doc describing how (?x) ignores spaces in character classes

Ian Graves has updated the pull request incrementally with one additional 
commit since the last revision:

  Rewording repetitive phrase

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4618/files
  - new: https://git.openjdk.java.net/jdk/pull/4618/files/11bafe80..521cddca

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=4618=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4618=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4618.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4618/head:pull/4618

PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-04-21 Thread Ian Graves 
> Clarifying note on comments mode to explicitly note that whitespace within 
> character classes is ignored.

Ian Graves has updated the pull request incrementally with one additional 
commit since the last revision:

  Tweaking wording and placement

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3577/files
  - new: https://git.openjdk.java.net/jdk/pull/3577/files/f4507e3a..79390124

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3577=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3577=01-02

  Stats: 11 lines in 1 file changed: 2 ins; 3 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3577.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3577/head:pull/3577

PR: https://git.openjdk.java.net/jdk/pull/3577