Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v10]
On Wed, 4 Nov 2020 14:51:06 GMT, Martin Doerr wrote: > Thanks for removing the branch from the loop. (Maybe this affects unrolling > decision.) Looks good. Yeah, it does, and oddly enough the best loop unroll value is now 1. I will re-run the benchmarks again to confirm, but that's what it's looking like now. - PR: https://git.openjdk.java.net/jdk/pull/293
Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v10]
On Tue, 3 Nov 2020 03:01:09 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing encodeBlock intrinsic. >> - Adds the code in HotSpot to check and martial the new intrinsic's >> arguments to the arch-specific intrinsic implementation >> - Adds a Power64LE-specific implementation of the decodeBlock intrinsic. >> - Adds a JMH microbenchmark for both Base64 encoding and encoding. >> - Enhances the JTReg hotspot intrinsic "TestBase64.java" regression test to >> more fully test both decoding and encoding. > > CoreyAshford has updated the pull request incrementally with one additional > commit since the last revision: > > stubGenerator_ppc.cpp: fix trailing whitespace errors Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/293
Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v10]
On Tue, 3 Nov 2020 03:01:09 GMT, CoreyAshford wrote: >> This patch set encompasses the following commits: >> >> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - >> decodeBlock(), and provides a flexible API for the intrinsic. The API is >> similar to the existing encodeBlock intrinsic. >> - Adds the code in HotSpot to check and martial the new intrinsic's >> arguments to the arch-specific intrinsic implementation >> - Adds a Power64LE-specific implementation of the decodeBlock intrinsic. >> - Adds a JMH microbenchmark for both Base64 encoding and encoding. >> - Enhances the JTReg hotspot intrinsic "TestBase64.java" regression test to >> more fully test both decoding and encoding. > > CoreyAshford has updated the pull request incrementally with one additional > commit since the last revision: > > stubGenerator_ppc.cpp: fix trailing whitespace errors Thanks for removing the branch from the loop. (Maybe this affects unrolling decision.) Looks good. - Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/293
Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v10]
> This patch set encompasses the following commits: > > - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - > decodeBlock(), and provides a flexible API for the intrinsic. The API is > similar to the existing encodeBlock intrinsic. > - Adds the code in HotSpot to check and martial the new intrinsic's arguments > to the arch-specific intrinsic implementation > - Adds a Power64LE-specific implementation of the decodeBlock intrinsic. > - Adds a JMH microbenchmark for both Base64 encoding and encoding. > - Enhances the JTReg hotspot intrinsic "TestBase64.java" regression test to > more fully test both decoding and encoding. CoreyAshford has updated the pull request incrementally with one additional commit since the last revision: stubGenerator_ppc.cpp: fix trailing whitespace errors - Changes: - all: https://git.openjdk.java.net/jdk/pull/293/files - new: https://git.openjdk.java.net/jdk/pull/293/files/0e291be4..8292527e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=293=09 - incr: https://webrevs.openjdk.java.net/?repo=jdk=293=08-09 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/293/head:pull/293 PR: https://git.openjdk.java.net/jdk/pull/293
