Re: RFR: 8254192: ExtraSharedClassListFile contains extra white space at end of line [v2]
On Thu, 15 Oct 2020 15:59:31 GMT, Calvin Cheung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comment adding \f for Replace > > Looks good. Thanks @iklam and @calvinccheung for the review. - PR: https://git.openjdk.java.net/jdk/pull/669
Re: RFR: 8254192: ExtraSharedClassListFile contains extra white space at end of line [v2]
On Thu, 15 Oct 2020 01:04:25 GMT, Yumin Qi wrote: >> Hi, Please review the simple change. >> >> The removing of white spaces from end of line in ClassListParser should be >> moved to before we add lambda-form-invoker >> line to array. After made such arrangement, changed CDS.java for trimming >> line code. >> >> Tests: local test on runtime/cds/appcds. Mach5 tier1,4 is in progress. >> >> Thanks > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment adding \f for Replace Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/669
Re: RFR: 8254192: ExtraSharedClassListFile contains extra white space at end of line [v2]
On Thu, 15 Oct 2020 01:04:25 GMT, Yumin Qi wrote: >> Hi, Please review the simple change. >> >> The removing of white spaces from end of line in ClassListParser should be >> moved to before we add lambda-form-invoker >> line to array. After made such arrangement, changed CDS.java for trimming >> line code. >> >> Tests: local test on runtime/cds/appcds. Mach5 tier1,4 is in progress. >> >> Thanks > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment adding \f for Replace Looks good. - Marked as reviewed by ccheung (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/669
Re: RFR: 8254192: ExtraSharedClassListFile contains extra white space at end of line [v2]
On Thu, 15 Oct 2020 01:04:25 GMT, Yumin Qi wrote: >> Hi, Please review the simple change. >> >> The removing of white spaces from end of line in ClassListParser should be >> moved to before we add lambda-form-invoker >> line to array. After made such arrangement, changed CDS.java for trimming >> line code. >> >> Tests: local test on runtime/cds/appcds. Mach5 tier1,4 is in progress. >> >> Thanks > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment adding \f for Replace Marked as reviewed by iklam (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/669
Re: RFR: 8254192: ExtraSharedClassListFile contains extra white space at end of line [v2]
> Hi, Please review the simple change. > > The removing of white spaces from end of line in ClassListParser should be > moved to before we add lambda-form-invoker > line to array. After made such arrangement, changed CDS.java for trimming > line code. > > Tests: local test on runtime/cds/appcds. Mach5 tier1,4 is in progress. > > Thanks Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Fix comment adding \f for Replace - Changes: - all: https://git.openjdk.java.net/jdk/pull/669/files - new: https://git.openjdk.java.net/jdk/pull/669/files/2086b3d8..f2984a4b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=669=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=669=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/669.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/669/head:pull/669 PR: https://git.openjdk.java.net/jdk/pull/669
