Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Joe Wang
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato  wrote:

>> This is to upgrade the CLDR data from version 39 to version 41 which was 
>> released yesterday. The vast majority of the changes are basically replacing 
>> the CLDR data, along with tools/testcase alignments. Here is the link to 
>> CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41
>
> Naoto Sato has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains 22 commits:
> 
>  - Merge branch 'master' into cldr+
>  - Merge branch 'master' into cldr+
>  - CLDR v41 final
>  - CLDR v41 beta2
>  - Merge branch 'master' into cldr+
>  - CLDR v41 alpha4
>  - Merge branch 'master' into cldr+
>  - Update copyright year to 2022
>  - CLDR release v40
>  - Merge branch 'master' into cldr
>  - ... and 12 more: 
> https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

Marked as reviewed by joehw (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Iris Clark
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato  wrote:

>> This is to upgrade the CLDR data from version 39 to version 41 which was 
>> released yesterday. The vast majority of the changes are basically replacing 
>> the CLDR data, along with tools/testcase alignments. Here is the link to 
>> CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41
>
> Naoto Sato has updated the pull request with a new target base due to a merge 
> or a rebase. The pull request now contains 22 commits:
> 
>  - Merge branch 'master' into cldr+
>  - Merge branch 'master' into cldr+
>  - CLDR v41 final
>  - CLDR v41 beta2
>  - Merge branch 'master' into cldr+
>  - CLDR v41 alpha4
>  - Merge branch 'master' into cldr+
>  - Update copyright year to 2022
>  - CLDR release v40
>  - Merge branch 'master' into cldr
>  - ... and 12 more: 
> https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Naoto Sato
> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Naoto Sato has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains 22 commits:

 - Merge branch 'master' into cldr+
 - Merge branch 'master' into cldr+
 - CLDR v41 final
 - CLDR v41 beta2
 - Merge branch 'master' into cldr+
 - CLDR v41 alpha4
 - Merge branch 'master' into cldr+
 - Update copyright year to 2022
 - CLDR release v40
 - Merge branch 'master' into cldr
 - ... and 12 more: https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d

-

Changes: https://git.openjdk.java.net/jdk/pull/8150/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8150&range=01
  Stats: 132400 lines in 859 files changed: 96406 ins; 4216 del; 31778 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8150.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8150/head:pull/8150

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41

2022-04-08 Thread Magnus Ihse Bursie
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato  wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by ihse (Reviewer).

Great, thanks!

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41

2022-04-08 Thread Naoto Sato
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato  wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

I measured the execution time of `CLDRConverter`. Each run measures an average 
execution time for 5 invocations of `CLDRConverter.main()`, and I ran it 5 
times for `java.base` and `jdk.localedata` modules. All average values are in 
seconds.

- Before the fix
  - java.base: 11.536 - 12.836
  - jdk.localedata: 19.764 - 22.584
- After the fix
  - java.base: 11.666 - 12.833
  - jdk.localedata: 19.183 - 20.838
 
Looking at the results, I don't see any notable tool execution time difference 
with this change.

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41

2022-04-08 Thread Magnus Ihse Bursie
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato  wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Have you checked if this update has any impact on the runtime of the 
CLDRConverter tool?

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Iris Clark
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato  wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8150


Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Joe Wang
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato  wrote:

> This is to upgrade the CLDR data from version 39 to version 41 which was 
> released yesterday. The vast majority of the changes are basically replacing 
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR 
> v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41

Marked as reviewed by joehw (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8150