Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ closing - and recreating against 17 - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 15:35:14 GMT, Maurizio Cimadamore wrote: > I can push to 17 if desired, but I'll need a new PR for that pushing to 17 would be nice; the script is equally broken and unusable there. - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ I can push to 17 if desired, but I'll need a new PR for that - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Does this need backported to 17 (or pushed to 17 and "back"ported into 18)? - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Agreed, let's back up and reevaluate. - Marked as reviewed by psandoz (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4492
