Re: RFR: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-28 Thread Vladimir Kozlov
On Wed, 28 Jul 2021 06:24:20 GMT, Jatin Bhateja  wrote:

> * Thanks for reporting it, should it be ok to move those tests to 
> ProblemList.txt and let me fix this as a follow up issue instead of a revert ?

@jatin-bhateja We did not test original changes in our testing infra. There 
could be other issues in high tiers which we don't know.
I prefer that you use 8271366 to prepare changes with fixed reported failure, 
file PR and let me run testing.

-

PR: https://git.openjdk.java.net/jdk/pull/4915


Re: RFR: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-27 Thread Jatin Bhateja
On Wed, 28 Jul 2021 05:35:59 GMT, Vladimir Kozlov  wrote:

> Backout the following changes due to vector tests failures in tier 2 and 
> later: 
> [JDK-8266054](https://bugs.openjdk.java.net/browse/JDK-8266054) VectorAPI 
> rotate operation optimization 
> 
> Changes also caused copyright header validation failure in Tier1 due to 
> missing `,` after copyright year in new test.
> 
> Currently running testing.

- Thanks for reporting it, should it be ok to move those tests to 
ProblemList.txt and let me fix this as a follow up issue instead of a revert ?

-

PR: https://git.openjdk.java.net/jdk/pull/4915


Re: RFR: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-27 Thread Ioi Lam
On Wed, 28 Jul 2021 05:35:59 GMT, Vladimir Kozlov  wrote:

> Backout the following changes due to vector tests failures in tier 2 and 
> later: 
> [JDK-8266054](https://bugs.openjdk.java.net/browse/JDK-8266054) VectorAPI 
> rotate operation optimization 
> 
> Changes also caused copyright header validation failure in Tier1 due to 
> missing `,` after copyright year in new test.
> 
> Currently running testing.

LGTM

-

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4915


Re: RFR: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization

2021-07-27 Thread David Holmes
On Wed, 28 Jul 2021 05:35:59 GMT, Vladimir Kozlov  wrote:

> Backout the following changes due to vector tests failures in tier 2 and 
> later: 
> [JDK-8266054](https://bugs.openjdk.java.net/browse/JDK-8266054) VectorAPI 
> rotate operation optimization 
> 
> Changes also caused copyright header validation failure in Tier1 due to 
> missing `,` after copyright year in new test.
> 
> Currently running testing.

Backout looks good.

Thanks,
David

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4915