Re: RFR: 8273098: Unnecessary Vector usage in java.naming

2021-08-30 Thread Daniel Fuchs 
On Thu, 26 Aug 2021 07:04:45 GMT, Andrey Turbanov 
 wrote:

> Usage of thread-safe collection Vector is unnecessary. It's recommended to 
> use ArrayList/array if a thread-safe implementation is not needed. In 
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where Vector was used as local variable.

Marked as reviewed by dfuchs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5262

Re: RFR: 8273098: Unnecessary Vector usage in java.naming

2021-08-30 Thread Aleksei Efimov 
On Thu, 26 Aug 2021 07:04:45 GMT, Andrey Turbanov 
 wrote:

> Usage of thread-safe collection Vector is unnecessary. It's recommended to 
> use ArrayList/array if a thread-safe implementation is not needed. In 
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where Vector was used as local variable.

Hi Andrey,

The changes look good to me.
I've run your patch through our CI and all JNDI tests are green.

Best,
Aleksei

-

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.java.net/jdk/pull/5262