Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-11-18 Thread Iris Clark 
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov  wrote:

> In couple of classes, result part of arrays of Pattern.split is compared with 
> `null`. Pattern.split (and hence String.split) never returns `null` in array 
> elements. Such comparisons are redundant.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5708

Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-11-18 Thread Roger Riggs 
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov  wrote:

> In couple of classes, result part of arrays of Pattern.split is compared with 
> `null`. Pattern.split (and hence String.split) never returns `null` in array 
> elements. Such comparisons are redundant.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5708

Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-10-04 Thread Weijun Wang 
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov 
 wrote:

> In couple of classes, result part of arrays of Pattern.split is compared with 
> `null`. Pattern.split (and hence String.split) never returns `null` in array 
> elements. Such comparisons are redundant.

Marked as reviewed by weijun (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5708

Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-09-27 Thread Sean Mullan 
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov 
 wrote:

> In couple of classes, result part of arrays of Pattern.split is compared with 
> `null`. Pattern.split (and hence String.split) never returns `null` in array 
> elements. Such comparisons are redundant.

The AlgorithmDecomposer change looks fine to me.

-

Marked as reviewed by mullan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5708