Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5718
Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Tue, 28 Sep 2021 11:28:42 GMT, Doug Lea wrote: > > > Just to be sure, does this include only the conditionally serializable > annotations in ForkJoinPool and ForkJoinTask in: > https://github.com/openjdk/jdk/pull/5718/files/a20d9afbd7b49b452b3c9bdc9f2d56442b5e2fc6 > If so, this looks OK to me. Yes, for java.util.concurrent, those are the only two changes needed to compile under the in-progress javac checks. - PR: https://git.openjdk.java.net/jdk/pull/5718
Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Just to be sure, does this include only the conditionally serializable annotations in ForkJoinPool and ForkJoinTask in: https://github.com/openjdk/jdk/pull/5718/files/a20d9afbd7b49b452b3c9bdc9f2d56442b5e2fc6 If so, this looks OK to me. - PR: https://git.openjdk.java.net/jdk/pull/5718
Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Looks okay but will need to go to the jsr166 cvs too (@DougLea). - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5718
Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5718
Re: RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy wrote: > Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial > checking are out for review (https://github.com/openjdk/jdk/pull/5709) and > java.util.concurrent would need some changes to pass under the expanded > checks. > > The changes are to suppress warnings where non-transient fields in > serializable types are not declared with a type statically known to be > serializable. That isn't necessarily a correctness issues, but it does merit > further scrutiny. > > In ForkJoinTask, the SuppressWarnings annotation previously applied in > JDK-8232230, seems to have been misplaced to a different field; this change > corrects it. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5718
