Re: RFR: 8274394: Use Optional.isEmpty instead of !Optional.isPresent in jdk.jlink

2021-09-28 Thread Mandy Chung 
On Sun, 26 Sep 2021 13:58:35 GMT, Andrey Turbanov 
 wrote:

> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty 
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.

LGTM

-

Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5707

Re: RFR: 8274394: Use Optional.isEmpty instead of !Optional.isPresent in jdk.jlink

2021-09-28 Thread Alan Bateman 
On Sun, 26 Sep 2021 13:58:35 GMT, Andrey Turbanov 
 wrote:

> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty 
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.

Looks okay, this code pre-dates the isEmpty method.

-

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5707