Re: RFR: 8281104: jar --create should create missing parent directories [v2]

2022-02-04 Thread Lance Andersen
On Fri, 4 Feb 2022 21:55:28 GMT, Christian Stein  wrote:

>> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing 
>> parent directories (here `a/b`) on the default file system before storing 
>> the JAR file (here `foo.jar`) in the destination directory.
>
> Christian Stein has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Extend help text for option `-c, --create`

The current changes look good overall

-

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7327


Re: RFR: 8281104: jar --create should create missing parent directories [v2]

2022-02-04 Thread Christian Stein
> Calling `jar --create --file a/b/foo.jar INPUT-FILES` should create missing 
> parent directories (here `a/b`) on the default file system before storing the 
> JAR file (here `foo.jar`) in the destination directory.

Christian Stein has updated the pull request incrementally with one additional 
commit since the last revision:

  Extend help text for option `-c, --create`

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7327/files
  - new: https://git.openjdk.java.net/jdk/pull/7327/files/f34e767a..65105a36

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7327&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7327&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7327.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7327/head:pull/7327

PR: https://git.openjdk.java.net/jdk/pull/7327