Re: RFR: 8284444: Sting typo [v3]
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes JFR changes look fine, thank you. - Marked as reviewed by mgronlun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v3]
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes The changes look fine to me now. Yet there are no changes in the client area any more. So you'll have to get additional approvals. - Marked as reviewed by aivanov (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v3]
On Wed, 6 Apr 2022 14:12:49 GMT, Daniel Jeliński wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 63:
>>
>>> 61: message.creating-association-with-null-extension=Creating association
>>> with null extension.
>>> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2}
>>> is required.
>>> 63: message.version-string-too-many-components=Version string may have up
>>> to 3 components - major.minor.build .
>>
>> I wonder whether the space before the period is required at the end of the
>> sentence. Perhaps, it's to separate a property name from the end of the
>> sentence.
>
> right; without the space the period would appear to be part of the version
> pattern.
Yes, I believe this is why it was done.
-
PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v3]
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote: >> This patch adds missing `r` in `string`s > > Daniel Jeliński has updated the pull request incrementally with two > additional commits since the last revision: > > - revert xalan changes > - revert icu changes The `jpackage` part of the fix looks good. Btw, there are translated files for 3 other languages (German, Japanese, Simplified Chinese), so I double-checked the translation for each, and they already say "string" (I guess whoever translated it just assumed it was meant to be "string" when they took the English phrase). - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/8125
Re: RFR: 8284444: Sting typo [v3]
> This patch adds missing `r` in `string`s Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision: - revert xalan changes - revert icu changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/8125/files - new: https://git.openjdk.java.net/jdk/pull/8125/files/68ce6ebd..1ec0314e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8125=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8125=01-02 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/8125.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8125/head:pull/8125 PR: https://git.openjdk.java.net/jdk/pull/8125
