Re: RFR: JDK-8179538: Update jdk.jdi to be HTML-5 friendly

2017-05-02 Thread serguei.spit...@oracle.com

Hi Kumar,

It looks fine to me too.

Thanks,
Serguei


On 5/2/17 16:23, Mandy Chung wrote:

Looks fine to me.

Mandy


On May 2, 2017, at 12:40 PM, Kumar Srinivasan  
wrote:

Hello,

Please review changes to make jdk.jdi HTML5 friendly,
table cell padding has not been addressed and will be fixed
separately, this takes care of others.

Note: Some of the errors were due to incorrect@throws but
in all cases there is the correct one further down, please use
sdiffs in these cases.

@throws {@link InvalidTypeException} if any

before:jdk.jdi {error=42, warning=1}
after: jdk.jdi {error=1}

http://cr.openjdk.java.net/~ksrini/8179538/webrev.00/index.html
https://bugs.openjdk.java.net/browse/JDK-8179538

Thanks
Kumar





Re: RFR: JDK-8179538: Update jdk.jdi to be HTML-5 friendly

2017-05-02 Thread Mandy Chung
Looks fine to me.

Mandy

> On May 2, 2017, at 12:40 PM, Kumar Srinivasan  
> wrote:
> 
> Hello,
> 
> Please review changes to make jdk.jdi HTML5 friendly,
> table cell padding has not been addressed and will be fixed
> separately, this takes care of others.
> 
> Note: Some of the errors were due to incorrect@throws but
> in all cases there is the correct one further down, please use
> sdiffs in these cases.
> 
> @throws {@link InvalidTypeException} if any
> 
> before:jdk.jdi {error=42, warning=1}
> after: jdk.jdi {error=1}
> 
> http://cr.openjdk.java.net/~ksrini/8179538/webrev.00/index.html
> https://bugs.openjdk.java.net/browse/JDK-8179538
> 
> Thanks
> Kumar
>