Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Brian Burkhalter]

Hi Ivan,

> On Jun 25, 2019, at 6:14 PM, Ivan Gerasimov  wrote:
> 
> On 6/25/19 3:33 PM, Joseph D. Darcy wrote:
>> Hello,
>> 
>> Please file a CSR for this change; thanks,
>> 
> 
> Filed: https://bugs.openjdk.java.net/browse/JDK-8226784 
> 
> 
> Please take a look at your convenience.

Reviewed.

Thanks,

Brian

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Ivan Gerasimov]

Hello!

On 6/25/19 3:33 PM, Joseph D. Darcy wrote:

Hello,

Please file a CSR for this change; thanks,



Filed: https://bugs.openjdk.java.net/browse/JDK-8226784

Please take a look at your convenience.

With kind regards,
Ivan


-Joe

On 6/25/2019 11:30 AM, Brent Christian wrote:
I was musing about this myself.  If the changes are within the 
@implNote(s), then perhaps not?


-Brent

On 6/25/19 11:15 AM, Brian Burkhalter wrote:
>

Is a CSR in order?

Thanks,

Brian

On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov 
 wrote:


Hello!

Would someone volunteer to review this extra-small doc-only fix?

Thanks in advance!

With kind regards,
Ivan


On 5/29/19 2:39 PM, Ivan Gerasimov wrote:

Hello!

In the implNote section of the javadoc for xxxSummaryStatistics 
classes it is mentioned that the sum is not checked for overflow.
It would be more accurate to add that neither does the 
implementation check the count for overflow.


Would you please help review this doc-only change?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8224716
WEBREV: http://cr.openjdk.java.net/~igerasim/8224716/00/webrev/



--
With kind regards,
Ivan Gerasimov







--
With kind regards,
Ivan Gerasimov

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Joseph D. Darcy]

Hello,

Please file a CSR for this change; thanks,

-Joe

On 6/25/2019 11:30 AM, Brent Christian wrote:
I was musing about this myself.  If the changes are within the 
@implNote(s), then perhaps not?


-Brent

On 6/25/19 11:15 AM, Brian Burkhalter wrote:
>

Is a CSR in order?

Thanks,

Brian

On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov 
 wrote:


Hello!

Would someone volunteer to review this extra-small doc-only fix?

Thanks in advance!

With kind regards,
Ivan


On 5/29/19 2:39 PM, Ivan Gerasimov wrote:

Hello!

In the implNote section of the javadoc for xxxSummaryStatistics 
classes it is mentioned that the sum is not checked for overflow.
It would be more accurate to add that neither does the 
implementation check the count for overflow.


Would you please help review this doc-only change?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8224716
WEBREV: http://cr.openjdk.java.net/~igerasim/8224716/00/webrev/



--
With kind regards,
Ivan Gerasimov

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Brent Christian]

I was musing about this myself.  If the changes are within the 
@implNote(s), then perhaps not?


-Brent

On 6/25/19 11:15 AM, Brian Burkhalter wrote:
>

Is a CSR in order?

Thanks,

Brian


On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov  wrote:

Hello!

Would someone volunteer to review this extra-small doc-only fix?

Thanks in advance!

With kind regards,
Ivan


On 5/29/19 2:39 PM, Ivan Gerasimov wrote:

Hello!

In the implNote section of the javadoc for xxxSummaryStatistics classes it is 
mentioned that the sum is not checked for overflow.
It would be more accurate to add that neither does the implementation check the 
count for overflow.

Would you please help review this doc-only change?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8224716
WEBREV: http://cr.openjdk.java.net/~igerasim/8224716/00/webrev/



--
With kind regards,
Ivan Gerasimov

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Brian Burkhalter]

Hi Ivan,

Looks OK to me. Is a CSR in order?

Thanks,

Brian

> On Jun 25, 2019, at 5:49 AM, Ivan Gerasimov  wrote:
> 
> Hello!
> 
> Would someone volunteer to review this extra-small doc-only fix?
> 
> Thanks in advance!
> 
> With kind regards,
> Ivan
> 
> 
> On 5/29/19 2:39 PM, Ivan Gerasimov wrote:
>> Hello!
>> 
>> In the implNote section of the javadoc for xxxSummaryStatistics classes it 
>> is mentioned that the sum is not checked for overflow.
>> It would be more accurate to add that neither does the implementation check 
>> the count for overflow.
>> 
>> Would you please help review this doc-only change?
>> 
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8224716
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8224716/00/webrev/
>> 
> 
> -- 
> With kind regards,
> Ivan Gerasimov

Re: RFR (XS) 8224716 : Javadoc of Int/Long/DoubleSummaryStatistics should mention possible overflow of count

[Ivan Gerasimov]

Hello!

Would someone volunteer to review this extra-small doc-only fix?

Thanks in advance!

With kind regards,
Ivan


On 5/29/19 2:39 PM, Ivan Gerasimov wrote:

Hello!

In the implNote section of the javadoc for xxxSummaryStatistics 
classes it is mentioned that the sum is not checked for overflow.
It would be more accurate to add that neither does the implementation 
check the count for overflow.


Would you please help review this doc-only change?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8224716
WEBREV: http://cr.openjdk.java.net/~igerasim/8224716/00/webrev/



--
With kind regards,
Ivan Gerasimov