Re: RFR [14/java.xml] 8178843: A bug in an inner loop in MethodGenerator's getLocals method

[Joe Wang]

Thanks Lance!

-Joe

On 7/10/19 6:38 PM, Lance Andersen wrote:

+1
On Jul 10, 2019, at 7:57 PM, Joe Wang > wrote:


Please review a cleanup that removes unused code. This code has two 
errors, one as indicated in the bug report, another attempting to 
loop through allVarsEverDeclared that was just created (meaning 
size=0). It just ensures again that the code was never used.


JBS: https://bugs.openjdk.java.net/browse/JDK-8178843
webrevs: http://cr.openjdk.java.net/~joehw/jdk14/8178843/webrev/

All tests passed.

Thanks,
Joe




Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR [14/java.xml] 8178843: A bug in an inner loop in MethodGenerator's getLocals method

[Lance Andersen]

+1
> On Jul 10, 2019, at 7:57 PM, Joe Wang  wrote:
> 
> Please review a cleanup that removes unused code. This code has two errors, 
> one as indicated in the bug report, another attempting to loop through 
> allVarsEverDeclared that was just created (meaning size=0). It just ensures 
> again that the code was never used.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8178843
> webrevs: http://cr.openjdk.java.net/~joehw/jdk14/8178843/webrev/
> 
> All tests passed.
> 
> Thanks,
> Joe

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com