Re: RFR - JDK-8215493 String::indent inconsistency with blank lines

[Roger Riggs]

Thanks, looks fine.  Roger

On 12/20/2018 11:46 AM, James Laskey wrote:

It’s there.  AlignIndent.java.

Sent from my iPhone


On Dec 20, 2018, at 12:10 PM, Roger Riggs  wrote:

Hi Jim,

Is there a missing test?  I'd expect to see a corresponding test change also.

otherwise, looks fine.

Regards, Roger



On 12/19/2018 03:13 PM, Jim Laskey wrote:
Please review these changes for jdk 12.

webrev: http://cr.openjdk.java.net/~jlaskey/8215493/webrev/index.html 


There is inconsistency with regards to blank lines and indentation. Adding indent space 
ignores blank lines, where subtraction indentation white space does not ignore blank 
lines. The solution is to remove the condition "Blank lines are unaffected" 
from the specification with appropriate changes to the implementation.

Thank you.

Cheers,

— Jim

CSR: https://bugs.openjdk.java.net/browse/JDK-8215499 

JBS: https://bugs.openjdk.java.net/browse/JDK-8215493 

Re: RFR - JDK-8215493 String::indent inconsistency with blank lines

[James Laskey]

It’s there.  AlignIndent.java. 

Sent from my iPhone

> On Dec 20, 2018, at 12:10 PM, Roger Riggs  wrote:
> 
> Hi Jim,
> 
> Is there a missing test?  I'd expect to see a corresponding test change also.
> 
> otherwise, looks fine.
> 
> Regards, Roger
> 
> 
>> On 12/19/2018 03:13 PM, Jim Laskey wrote:
>> Please review these changes for jdk 12.
>> 
>> webrev: http://cr.openjdk.java.net/~jlaskey/8215493/webrev/index.html 
>> 
>> 
>> There is inconsistency with regards to blank lines and indentation. Adding 
>> indent space ignores blank lines, where subtraction indentation white space 
>> does not ignore blank lines. The solution is to remove the condition "Blank 
>> lines are unaffected" from the specification with appropriate changes to the 
>> implementation.
>> 
>> Thank you.
>> 
>> Cheers,
>> 
>> — Jim
>> 
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8215499 
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215493 
>> 
>> 
>> 
> 

Re: RFR - JDK-8215493 String::indent inconsistency with blank lines

[Roger Riggs]

Hi Jim,

Is there a missing test?  I'd expect to see a corresponding test change 
also.


otherwise, looks fine.

Regards, Roger


On 12/19/2018 03:13 PM, Jim Laskey wrote:

Please review these changes for jdk 12.

webrev: http://cr.openjdk.java.net/~jlaskey/8215493/webrev/index.html 


There is inconsistency with regards to blank lines and indentation. Adding indent space 
ignores blank lines, where subtraction indentation white space does not ignore blank 
lines. The solution is to remove the condition "Blank lines are unaffected" 
from the specification with appropriate changes to the implementation.

Thank you.

Cheers,

— Jim

CSR: https://bugs.openjdk.java.net/browse/JDK-8215499 

JBS: https://bugs.openjdk.java.net/browse/JDK-8215493